content/renderer/media/webrtc/media_stream_remote_audio_track.h - Issue 1721273002: MediaStream audio object graph untangling and clean-ups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/media_stream_remote_audio_track.h

Issue 1721273002: MediaStream audio object graph untangling and clean-ups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed mcasas's 1st round comments, plus REBASE. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_stream_audio_track.cc ('K') | « content/renderer/media/webaudio_capturer_source.cc ('k') | content/renderer/media/webrtc/media_stream_remote_audio_track.cc » ('j') | content/renderer/media/webrtc/media_stream_remote_audio_track.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc/media_stream_remote_audio_track.h

diff --git a/content/renderer/media/webrtc/media_stream_remote_audio_track.h b/content/renderer/media/webrtc/media_stream_remote_audio_track.h

index e2a6eaa9dd98136685e51fa5d48d2fbfb3910531..f8a10133f207995ae376d61b1242e07053e27b07 100644

--- a/content/renderer/media/webrtc/media_stream_remote_audio_track.h

+++ b/content/renderer/media/webrtc/media_stream_remote_audio_track.h

@@ -26,7 +26,6 @@ class MediaStreamRemoteAudioTrack : public MediaStreamAudioTrack {

~MediaStreamRemoteAudioTrack() override;

void SetEnabled(bool enabled) override;

- void Stop() override;

void AddSink(MediaStreamAudioSink* sink) override;

void RemoveSink(MediaStreamAudioSink* sink) override;

@@ -44,6 +43,7 @@ class MediaStreamRemoteAudioTrack : public MediaStreamAudioTrack {

// Inheriting from ExtraData directly since MediaStreamAudioSource has

// too much unrelated bloat.

// TODO(tommi): MediaStreamAudioSource needs refactoring.

+// TODO(miu): On it! ;-)

class MediaStreamRemoteAudioSource

: public blink::WebMediaStreamSource::ExtraData {

public: