Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: content/renderer/media/webrtc/media_stream_remote_audio_track.h

Issue 1721273002: MediaStream audio object graph untangling and clean-ups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit tests broken by recent MSAudioTrack::Stop() reworking. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc/media_stream_remote_audio_track.h
diff --git a/content/renderer/media/webrtc/media_stream_remote_audio_track.h b/content/renderer/media/webrtc/media_stream_remote_audio_track.h
index e2a6eaa9dd98136685e51fa5d48d2fbfb3910531..4bc85d4257c3736cc270f0f8368b72cfeec1feeb 100644
--- a/content/renderer/media/webrtc/media_stream_remote_audio_track.h
+++ b/content/renderer/media/webrtc/media_stream_remote_audio_track.h
@@ -25,9 +25,10 @@ class MediaStreamRemoteAudioTrack : public MediaStreamAudioTrack {
const blink::WebMediaStreamSource& source, bool enabled);
~MediaStreamRemoteAudioTrack() override;
+ // MediaStreamTrack override.
void SetEnabled(bool enabled) override;
- void Stop() override;
+ // MediaStreamAudioTrack overrides.
void AddSink(MediaStreamAudioSink* sink) override;
void RemoveSink(MediaStreamAudioSink* sink) override;
media::AudioParameters GetOutputFormat() const override;
@@ -35,6 +36,9 @@ class MediaStreamRemoteAudioTrack : public MediaStreamAudioTrack {
webrtc::AudioTrackInterface* GetAudioAdapter() override;
private:
+ // MediaStreamAudioTrack override.
+ void OnStop() final;
+
MediaStreamRemoteAudioSource* source() const;
blink::WebMediaStreamSource source_;
@@ -44,6 +48,7 @@ class MediaStreamRemoteAudioTrack : public MediaStreamAudioTrack {
// Inheriting from ExtraData directly since MediaStreamAudioSource has
// too much unrelated bloat.
// TODO(tommi): MediaStreamAudioSource needs refactoring.
+// TODO(miu): On it! ;-)
tommi (sloooow) - chröme 2016/03/03 11:07:30 w00t! :D
class MediaStreamRemoteAudioSource
: public blink::WebMediaStreamSource::ExtraData {
public:

Powered by Google App Engine
This is Rietveld 408576698