content/renderer/media/track_audio_renderer.cc - Issue 1721273002: MediaStream audio object graph untangling and clean-ups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/track_audio_renderer.cc

Issue 1721273002: MediaStream audio object graph untangling and clean-ups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit tests broken by recent MSAudioTrack::Stop() reworking. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_stream_audio_source.cc ('K') | « content/renderer/media/speech_recognition_audio_sink_unittest.cc ('k') | content/renderer/media/user_media_client_impl.cc » ('j') | content/renderer/media/webrtc/media_stream_remote_audio_track.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/track_audio_renderer.cc

diff --git a/content/renderer/media/track_audio_renderer.cc b/content/renderer/media/track_audio_renderer.cc

index 3a764c05eceaea9ef71c6a57baa49bf407959f9d..23f2dadd52af10b6f2ce3df1849d1007dea8209c 100644

--- a/content/renderer/media/track_audio_renderer.cc

+++ b/content/renderer/media/track_audio_renderer.cc

@@ -131,7 +131,7 @@ TrackAudioRenderer::TrackAudioRenderer(

security_origin_(security_origin),

volume_(0.0),

sink_started_(false) {

- DCHECK(MediaStreamAudioTrack::GetTrack(audio_track_));

+ DCHECK(MediaStreamAudioTrack::From(audio_track_));

DVLOG(1) << "TrackAudioRenderer::TrackAudioRenderer()";

}

@@ -237,7 +237,7 @@ base::TimeDelta TrackAudioRenderer::GetCurrentRenderTime() const {

bool TrackAudioRenderer::IsLocalRenderer() const {

DCHECK(task_runner_->BelongsToCurrentThread());

- return MediaStreamAudioTrack::GetTrack(audio_track_)->is_local_track();

+ return MediaStreamAudioTrack::From(audio_track_)->is_local_track();

}

void TrackAudioRenderer::SwitchOutputDevice(