content/renderer/media/media_stream_renderer_factory_impl.cc - Issue 1721273002: MediaStream audio object graph untangling and clean-ups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_renderer_factory_impl.cc

Issue 1721273002: MediaStream audio object graph untangling and clean-ups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit tests broken by recent MSAudioTrack::Stop() reworking. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_stream_audio_source.cc ('K') | « content/renderer/media/media_stream_center.cc ('k') | content/renderer/media/mock_media_stream_registry.cc » ('j') | content/renderer/media/webrtc/media_stream_remote_audio_track.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_renderer_factory_impl.cc

diff --git a/content/renderer/media/media_stream_renderer_factory_impl.cc b/content/renderer/media/media_stream_renderer_factory_impl.cc

index e480d9f59779d9185ad81245144801c95208a266..f31dde18b370555d140bdb992a46c82e1e33ca42 100644

--- a/content/renderer/media/media_stream_renderer_factory_impl.cc

+++ b/content/renderer/media/media_stream_renderer_factory_impl.cc

@@ -109,8 +109,8 @@ MediaStreamRendererFactoryImpl::GetAudioRenderer(

// and mixes audio from all the tracks that belong to the media stream.

// For now, we have separate renderers depending on if the first audio track

// in the stream is local or remote.

- MediaStreamAudioTrack* audio_track = MediaStreamAudioTrack::GetTrack(

- audio_tracks[0]);

+ MediaStreamAudioTrack* audio_track =

+ MediaStreamAudioTrack::From(audio_tracks[0]);

if (!audio_track) {

// This can happen if the track was cloned.

// TODO(tommi, perkj): Fix cloning of tracks to handle extra data too.