content/renderer/media/media_recorder_handler.cc - Issue 1721273002: MediaStream audio object graph untangling and clean-ups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_recorder_handler.cc

Issue 1721273002: MediaStream audio object graph untangling and clean-ups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit tests broken by recent MSAudioTrack::Stop() reworking. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/renderer/media_stream_audio_sink.cc ('K') | « content/renderer/media/audio_track_recorder_unittest.cc ('k') | content/renderer/media/media_stream_audio_level_calculator.h » ('j') | content/renderer/media/media_stream_audio_level_calculator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_recorder_handler.cc

diff --git a/content/renderer/media/media_recorder_handler.cc b/content/renderer/media/media_recorder_handler.cc

index e43502e48ee55e1f5c6452702000338237f2f81f..b734af8e6ffe1e1509aec27a623461d1f3b961d1 100644

--- a/content/renderer/media/media_recorder_handler.cc

+++ b/content/renderer/media/media_recorder_handler.cc

@@ -135,8 +135,7 @@ bool MediaRecorderHandler::start(int timeslice) {

}

const bool use_audio_tracks =

- !audio_tracks.isEmpty() &&

- MediaStreamAudioTrack::GetTrack(audio_tracks[0]);

+ !audio_tracks.isEmpty() && MediaStreamAudioTrack::From(audio_tracks[0]);

webm_muxer_.reset(new media::WebmMuxer(

use_vp9_ ? media::kCodecVP9 : media::kCodecVP8,