Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Issue 1721243002: [turbofan] Ship TurboFan inlining. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Ship TurboFan inlining. Until now inlining in TurboFan was staged behind --turbo, which means that it wasn't enabled with --turbo-shipping. It seems reasonable to ship it now, since Clusterfuzz had fun with it for a year already, and we need to reach parity with Crankshaft with more and more things being enabled behind --turbo-shipping. Committed: https://crrev.com/be65129e6588d7ae26751b70c6094ad2f6ec99bb Cr-Commit-Position: refs/heads/master@{#34209}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/flag-definitions.h View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Benedikt Meurer
Hey Michi, Let's turn this on for real. Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-02-23 08:43:54 UTC) #2
Michael Starzinger
LGTM.
4 years, 10 months ago (2016-02-23 09:00:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1721243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1721243002/1
4 years, 10 months ago (2016-02-23 09:03:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 09:04:45 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/be65129e6588d7ae26751b70c6094ad2f6ec99bb Cr-Commit-Position: refs/heads/master@{#34209}
4 years, 10 months ago (2016-02-23 09:05:45 UTC) #8
Michael Achenbach
4 years, 10 months ago (2016-02-24 10:25:20 UTC) #9
Message was sent while issue was closed.
This slowed down mjsunit/array-natives-elements in stress mode.
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/buil...

Could you fix that up? The test got more than 10x slower.

Powered by Google App Engine
This is Rietveld 408576698