Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: src/core/SkLinearBitmapPipeline.cpp

Issue 1721153002: remove unnecessary copies (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkLinearBitmapPipeline.cpp
diff --git a/src/core/SkLinearBitmapPipeline.cpp b/src/core/SkLinearBitmapPipeline.cpp
index f3b281aac77b4e126e0d887b6ab13fd6594d951d..02a4bd39f3df869a5d6a75284da472bb636646e2 100644
--- a/src/core/SkLinearBitmapPipeline.cpp
+++ b/src/core/SkLinearBitmapPipeline.cpp
@@ -133,17 +133,13 @@ public:
, fStrategy{std::forward<Args>(args)...}{ }
void VECTORCALL pointListFew(int n, Sk4f xs, Sk4f ys) override {
- Sk4f newXs = xs;
- Sk4f newYs = ys;
- fStrategy.processPoints(&newXs, &newYs);
- fNext->pointListFew(n, newXs, newYs);
+ fStrategy.processPoints(&xs, &ys);
+ fNext->pointListFew(n, xs, ys);
}
void VECTORCALL pointList4(Sk4f xs, Sk4f ys) override {
- Sk4f newXs = xs;
- Sk4f newYs = ys;
- fStrategy.processPoints(&newXs, &newYs);
- fNext->pointList4(newXs, newYs);
+ fStrategy.processPoints(&xs, &ys);
+ fNext->pointList4(xs, ys);
}
void pointSpan(SkPoint start, SkScalar length, int count) override {
@@ -167,24 +163,18 @@ public:
, fStrategy{std::forward<Args>(args)...}{ }
void VECTORCALL pointListFew(int n, Sk4f xs, Sk4f ys) override {
- Sk4f newXs = xs;
- Sk4f newYs = ys;
- fStrategy.processPoints(&newXs, &newYs);
- fNext->pointListFew(n, newXs, newYs);
+ fStrategy.processPoints(&xs, &ys);
+ fNext->pointListFew(n, xs, ys);
}
void VECTORCALL pointList4(Sk4f xs, Sk4f ys) override {
- Sk4f newXs = xs;
- Sk4f newYs = ys;
- fStrategy.processPoints(&newXs, &newYs);
- fNext->pointList4(newXs, newYs);
+ fStrategy.processPoints(&xs, &ys);
+ fNext->pointList4(xs, ys);
}
void VECTORCALL bilerpList(Sk4f xs, Sk4f ys) override {
- Sk4f newXs = xs;
- Sk4f newYs = ys;
- fStrategy.processPoints(&newXs, &newYs);
- fNext->bilerpList(newXs, newYs);
+ fStrategy.processPoints(&xs, &ys);
+ fNext->bilerpList(xs, ys);
}
void pointSpan(SkPoint start, SkScalar length, int count) override {
@@ -202,7 +192,7 @@ class SkippedStage final : public SkLinearBitmapPipeline::BilerpProcessorInterfa
void VECTORCALL pointListFew(int n, Sk4f xs, Sk4f ys) override {
SkFAIL("Skipped stage.");
}
- void VECTORCALL pointList4(Sk4f Xs, Sk4f Ys) override {
+ void VECTORCALL pointList4(Sk4f xs, Sk4f ys) override {
SkFAIL("Skipped stage.");
}
void VECTORCALL bilerpList(Sk4f xs, Sk4f ys) override {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698