Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 172113002: Fix crash when .mhtml/.pdf files are opened from download shelf on Chrome OS. (Closed)

Created:
6 years, 10 months ago by kinaba
Modified:
6 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Fix crash when .mhtml/.pdf files are opened from download shelf on Chrome OS. BUG=344808 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252055

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/chromeos/file_manager/file_browser_handlers.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
kinaba
Sorry I couldn't catch this during the review...
6 years, 10 months ago (2014-02-19 09:06:33 UTC) #1
hirono
On 2014/02/19 09:06:33, kinaba wrote: > Sorry I couldn't catch this during the review... I ...
6 years, 10 months ago (2014-02-19 09:20:36 UTC) #2
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 10 months ago (2014-02-19 09:21:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/172113002/1
6 years, 10 months ago (2014-02-19 09:22:05 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 12:16:47 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=266288
6 years, 10 months ago (2014-02-19 12:16:48 UTC) #6
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 10 months ago (2014-02-19 12:46:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/172113002/1
6 years, 10 months ago (2014-02-19 12:46:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/172113002/1
6 years, 10 months ago (2014-02-19 14:58:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/172113002/1
6 years, 10 months ago (2014-02-19 15:28:44 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 19:55:45 UTC) #11
Message was sent while issue was closed. 
Change committed as 252055

Powered by Google App Engine
This is Rietveld 408576698