Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1721073004: Switch from _DEBUG to NDEBUG. (Closed)

Created:
4 years, 10 months ago by Lei Zhang
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch from _DEBUG to NDEBUG. - NDEBUG is more widely used in Chromium - _DEBUG is not defined on Mac in Chromium - Leaving _DEBUG in for standalone debug builds for the benefit of third party libraries / Windows. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e4ac3369dc7bb1d0ae913404f008aea1fcd92480

Patch Set 1 #

Total comments: 1

Patch Set 2 : ifndef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M core/include/fxcrt/fx_system.h View 1 2 chunks +1 line, -5 lines 0 comments Download
M core/src/fxcrt/fx_basic_wstring.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_fm2jscontext.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
NDEBUG it is.
4 years, 10 months ago (2016-02-23 00:20:12 UTC) #2
Tom Sepez
https://codereview.chromium.org/1721073004/diff/1/core/src/fxcrt/fx_basic_wstring.cpp File core/src/fxcrt/fx_basic_wstring.cpp (right): https://codereview.chromium.org/1721073004/diff/1/core/src/fxcrt/fx_basic_wstring.cpp#newcode18 core/src/fxcrt/fx_basic_wstring.cpp:18: #if !defined(NDEBUG) dunno, I kinda prefer #ifndef NDEBUG, maybe ...
4 years, 10 months ago (2016-02-23 00:38:45 UTC) #3
Lei Zhang
On 2016/02/23 00:38:45, Tom Sepez wrote: > https://codereview.chromium.org/1721073004/diff/1/core/src/fxcrt/fx_basic_wstring.cpp > File core/src/fxcrt/fx_basic_wstring.cpp (right): > > https://codereview.chromium.org/1721073004/diff/1/core/src/fxcrt/fx_basic_wstring.cpp#newcode18 ...
4 years, 10 months ago (2016-02-23 00:43:57 UTC) #4
Tom Sepez
lgtm
4 years, 10 months ago (2016-02-23 00:44:56 UTC) #5
Lei Zhang
4 years, 10 months ago (2016-02-23 00:47:26 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
e4ac3369dc7bb1d0ae913404f008aea1fcd92480 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698