Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 172103007: Fix bench to compile when SK_SUPPORTS_GPU is not provided as a compiler option (Closed)

Created:
6 years, 10 months ago by Chris Dalton
Modified:
6 years, 10 months ago
Reviewers:
djsollen, bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix bench to compile when SK_SUPPORTS_GPU is not provided as a compiler option In the case that SK_SUPPORTS_GPU is not provided to the compiler, the value is either defined in in the SkUserConfig.h or SkPostConfig.h. Prior to this change HairlinePathBench would test that value before including anything, which led to build errors. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13502

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M bench/HairlinePathBench.cpp View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Chris Dalton
6 years, 10 months ago (2014-02-19 19:03:40 UTC) #1
bsalomon
lgtm
6 years, 10 months ago (2014-02-19 19:16:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/172103007/1
6 years, 10 months ago (2014-02-19 19:17:02 UTC) #3
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 19:30:43 UTC) #4
Message was sent while issue was closed.
Change committed as 13502

Powered by Google App Engine
This is Rietveld 408576698