Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 172103004: Run SPD in a single-threaded mode. (Closed)

Created:
6 years, 10 months ago by Alexander Potapenko
Modified:
6 years, 10 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews
Visibility:
Public.

Description

Run SPD in a single-threaded mode. This prevents libspeechd from hanging in getline() indefinitely, which may lock other threads that are trying to fflush all the open files. BUG=333003 R=dtseng@chromium.org,dmazzoni@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252113

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/speech/tts_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexander Potapenko
Please take a look.
6 years, 10 months ago (2014-02-19 16:34:34 UTC) #1
dmazzoni
lgtm Sounds great, I didn't realize that would fix it.
6 years, 10 months ago (2014-02-19 17:01:05 UTC) #2
David Tseng
LGTM We should verify that queueing new utterances still works, but I agree this is ...
6 years, 10 months ago (2014-02-19 17:15:57 UTC) #3
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 10 months ago (2014-02-19 17:19:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/172103004/1
6 years, 10 months ago (2014-02-19 17:22:04 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 22:11:17 UTC) #6
Message was sent while issue was closed.
Change committed as 252113

Powered by Google App Engine
This is Rietveld 408576698