Issue 172103003: Added resources for in-session captive portal notification.

Issue 172103003: Added resources for in-session captive portal notification. (Closed)

Created:
6 years, 10 months ago by ygorshenin1

Modified:
6 years, 10 months ago

Reviewers:
oshima

CC:
chromium-reviews, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added resources for in-session captive portal notification. BUG=240237 TEST=none R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252278

Patch Set 2 : Resources are moved to cros. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
A	chrome/app/theme/default_100_percent/cros/captive_portal_icon.png	View	1	Binary file		0 comments	Download
A	chrome/app/theme/default_100_percent/cros/globe_icon.png	View	1	Binary file		0 comments	Download
A	chrome/app/theme/default_200_percent/cros/captive_portal_icon.png	View	1	Binary file		0 comments	Download
A	chrome/app/theme/default_200_percent/cros/globe_icon.png	View	1	Binary file		0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

oshima

https://codereview.chromium.org/172103003/diff/1/chrome/app/theme/theme_resources.grd File chrome/app/theme/theme_resources.grd (right): https://codereview.chromium.org/172103003/diff/1/chrome/app/theme/theme_resources.grd#newcode506 chrome/app/theme/theme_resources.grd:506: <structure type="chrome_scaled_image" name="IDR_PORTAL_DETECTION_GLOBE" file="common/globe_icon.png" /> If they're cros only, ...

6 years, 10 months ago (2014-02-19 18:43:55 UTC) #2

ygorshenin1

PTAL https://codereview.chromium.org/172103003/diff/1/chrome/app/theme/theme_resources.grd File chrome/app/theme/theme_resources.grd (right): https://codereview.chromium.org/172103003/diff/1/chrome/app/theme/theme_resources.grd#newcode506 chrome/app/theme/theme_resources.grd:506: <structure type="chrome_scaled_image" name="IDR_PORTAL_DETECTION_GLOBE" file="common/globe_icon.png" /> On 2014/02/19 18:43:55, ...

6 years, 10 months ago (2014-02-20 13:33:41 UTC) #3

ygorshenin1

6 years, 10 months ago (2014-02-20 17:05:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r252278 (presubmit successful).

Expand Messages | Collapse Messages