Connectivity Diagnostics API: chrome.diagnostics.sendPacket

chrome/browser/extensions/api/diagnostics/diagnostics_api.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/api/diagnostics/diagnostics_api.h"
+
+#include "chrome/browser/extensions/api/diagnostics/send_ping_packet.h"
+
+namespace SendPacket = extensions::api::diagnostics::SendPacket;
+
+using base::Callback;
+
+namespace {
+
+const char kErrorPingNotImplemented[] = "Not implemented.";
+const char kErrorPingFailed[] = "Failed to send ping packet.";

[asargent_no_longer_on_chrome, 2013/06/20 22:51:29]

nit: I think we usually don't end the developer-readable error messages with a
'.' character.

[Bei Zhang, 2013/06/21 08:31:07]

Done.

+
+}
+
+namespace extensions {
+
+DiagnosticsSendPacketFunction::DiagnosticsSendPacketFunction() {}
+
+DiagnosticsSendPacketFunction::~DiagnosticsSendPacketFunction() {}
+
+bool DiagnosticsSendPacketFunction::Prepare() {
+  parameters_ = SendPacket::Params::Create(*args_);
+  EXTENSION_FUNCTION_VALIDATE(parameters_.get());
+  return true;
+}
+
+void DiagnosticsSendPacketFunction::AsyncWorkStart() {
+  extensions::SendPingPacket(
+      parameters_->options.ip,
+      parameters_->options.ttl.get(),
+      parameters_->options.timeout.get(),
+      parameters_->options.size.get(),
+      base::Bind(&DiagnosticsSendPacketFunction::OnComplete, this));
+}
+
+bool DiagnosticsSendPacketFunction::Respond() {
+  return error_.empty();
+}
+
+void DiagnosticsSendPacketFunction::OnComplete(
+    SendPingPacketResultCode result_code,
+    const std::string& ip,
+    double latency) {
+
+  switch (result_code) {
+    case extensions::SEND_PING_PACKET_OK: {
+      extensions::api::diagnostics::SendPacketResult result;
+      result.ip = ip;
+      result.latency = latency;
+      SetResult(result.ToValue().release());
+      break;
+    }
+    case extensions::SEND_PING_PACKET_NOT_IMPLEMENTED:
+      SetError(kErrorPingNotImplemented);
+      break;
+    case extensions::SEND_PING_PACKET_FAILED:
+      SetError(kErrorPingFailed);
+      break;
+  }

[xiaowenx, 2013/06/20 19:42:44]

Do you want to have a default case that also does
SetError(kErrorPingNotImplemented)?

[Bei Zhang, 2013/06/21 08:31:07]

default case for enums are not recommended as it makes it hard to locate a
missing case. We have an automatic tool to check if all the cases are covered.  

On 2013/06/20 19:42:44, xiaowenx wrote:

+  AsyncWorkCompleted();
+}
+
+}  // namespace extensions