Connectivity Diagnostics API: chrome.diagnostics.sendPacket

chrome/browser/extensions/api/diagnostics/send_ping_packet.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_API_DIAGNOSTICS_SEND_PING_PACKET_H_
+#define CHROME_BROWSER_EXTENSIONS_API_DIAGNOSTICS_SEND_PING_PACKET_H_
+
+#include <string>
+
+#include "base/callback.h"
+
+namespace extensions {
+

[not at google - send to devlin, 2013/06/20 23:32:12]

this should be in a second nested namespace like send_ping_packet, and the names
updated accordingly.

I am somewhat confused why it isn't a class, though. It seems idiomatically a
class, and I've seen that pattern many times for cross-platform things. I.e. the
class has a static method like Create().

[Bei Zhang, 2013/06/21 08:31:07]

Done.

+enum SendPingPacketResultCode {
+  SEND_PING_PACKET_OK,
+  SEND_PING_PACKET_NOT_IMPLEMENTED,
+  SEND_PING_PACKET_FAILED,
+};
+
+// Callback for extensions::SendPingPacket
+typedef base::Callback<void(SendPingPacketResultCode result_code,
+                            const std::string& ip,
+                            double latency)>
+  SendPingPacketCallback;
+
+// Sends an ICMP packet with given parameters.
+// Passes NULL for omitted arguments.

[not at google - send to devlin, 2013/06/20 23:32:12]

You need to document that callback can be called synchronously - or just always
make sure to reply on MessageLoop::current().

[Bei Zhang, 2013/06/21 08:31:07]

I removed this method. Now it's a private method inside
extensions::DiagnosticsSendPacketFunction

On 2013/06/20 23:32:12, kalman wrote:

+void SendPingPacket(
+    const std::string& ip,
+    const int* ttl,

[not at google - send to devlin, 2013/06/20 23:32:12]

as I said in the other file, it would be cleaner to just pass the whole options
into here.

[Bei Zhang, 2013/06/21 08:31:07]

Done.

+    const int* timeout,
+    const int* size,
+    const SendPingPacketCallback& callback);
+
+}  // namespace extensions
+
+#endif  // CHROME_BROWSER_EXTENSIONS_API_DIAGNOSTICS_SEND_PING_PACKET_H_