Connectivity Diagnostics API: chrome.diagnostics.sendPacket

chrome/browser/extensions/api/diagnostics/diagnostics_api.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_API_DIAGNOSTICS_DIAGNOSTICS_API_H_
+#define CHROME_BROWSER_EXTENSIONS_API_DIAGNOSTICS_DIAGNOSTICS_API_H_
+
+#include <string>
+
+#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/extensions/api/api_function.h"
+#include "chrome/browser/extensions/api/diagnostics/send_ping_packet.h"
+#include "chrome/common/extensions/api/diagnostics.h"
+
+namespace extensions {
+
+class DiagnosticsSendPacketFunction : public AsyncApiFunction {

[not at google - send to devlin, 2013/06/20 23:32:12]

What thread does this stuff happen on? Is it the UI thread? In which case using
just an AsyncExtensionFunction would be simpler, you only need to implement
RunImpl (and for that matter I actually find AsyncApiFunction quite a
confusingly indirect class).

[Bei Zhang, 2013/06/21 08:31:07]

AsyncApiFunction works on IO thread.

On 2013/06/20 23:32:12, kalman wrote:

[not at google - send to devlin, 2013/06/21 17:13:24]

Ok. Could you add some DCHECK(CurrentyOn(IO))s around the place then. That isn't
clear.

[Bei Zhang, 2013/06/21 19:31:44]

Actually all the apps APIs are by default works on IO thread. More specifically
the pattern we are using is that PrePrepare and Prepare happens on UI thread and
AsyncWorkStart starts on IO thread. AsyncWorkComplete can be invoked on any
thread.  Following this pattern we probably don't need to DCHECK the thread
here. 

On 2013/06/21 17:13:24, kalman wrote:

+ public:
+  DECLARE_EXTENSION_FUNCTION("diagnostics.sendPacket",
+                             DIAGNOSTICS_SENDPACKET);
+  DiagnosticsSendPacketFunction();
+
+ protected:
+  virtual ~DiagnosticsSendPacketFunction();
+
+  // AsyncApiFunction:
+  virtual bool Prepare() OVERRIDE;
+  virtual void AsyncWorkStart() OVERRIDE;
+  virtual bool Respond() OVERRIDE;
+
+ private:
+  void OnComplete(SendPingPacketResultCode result_code,
+                  const std::string& ip,
+                  double latency);
+
+  scoped_ptr<extensions::api::diagnostics::SendPacket::Params>
+      parameters_;
+};
+
+}  // namespace extensions
+
+#endif  // CHROME_BROWSER_EXTENSIONS_API_DIAGNOSTICS_DIAGNOSTICS_API_H_