Connectivity Diagnostics API: chrome.diagnostics.sendPacket

chromeos/dbus/packet_sender.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMEOS_DBUS_PACKET_SENDER_H_
+#define CHROMEOS_DBUS_PACKET_SENDER_H_
+
+#include "base/callback.h"
+#include "base/values.h"
+#include "chromeos/chromeos_export.h"
+
+namespace chromeos {
+
+class CHROMEOS_EXPORT PacketSender {
+ public:
+  typedef base::Callback<void(bool succeeded,
+                              std::string ip, int latency)> SendCallback;

[xiaowenx, 2013/06/17 06:19:38]

can we use const std::string& ip here?

[Bei Zhang, 2013/06/17 07:30:54]

Done.

[Bei Zhang, 2013/06/17 07:30:54]

Done.

+  PacketSender();
+  virtual ~PacketSender();

[xiaowenx, 2013/06/17 06:19:38]

is there a reason to use virtual destructor?

+  void Send(std::string ip, std::string type, int ttl, int timeout, int size,

[xiaowenx, 2013/06/17 06:19:38]

can we use const std::string& ip here?

[Bei Zhang, 2013/06/17 07:30:54]

Done.

+            const SendCallback& callback);
+
+  static PacketSender* GetInstance();
+ private:
+  void OnSend(const SendCallback& callback,
+              bool succeeded, const std::string& reply);
+};
+
+}  // namespace chromeos

[xiaowenx, 2013/06/17 06:19:38]

it looks better to insert an empty line here :)

[Bei Zhang, 2013/06/17 07:30:54]

Done.

+#endif  // CHROMEOS_DBUS_PACKET_SENDER_H_