Initial hermetic package analyzer.

Initial hermetic package analyzer.

When --package-mode is specified, this turns ON the single package
analysis mode. My initial idea was to accept a single path - the root
folder of the package and analyze the package completely as Dart
Analysis Server does. But later I decided to accept a list of files
to analyze, at least for now.

We still need the --package-mode-path option with the path to the root
folder of the package because we need to know which libraries are in
the 'lib' folder and write these libraries into the output summary.

The option --package-name is used to write the same URIs into
summary as the clients are going to use to refer the package
libraries, and also as the package references itself.

Multiple --package-summary-input=pkg,summary options can be specified,
one for each package. Every referenced package (except itself) must
be listed.

If --package-summary-output is specified, the output summary of
the package is written to the specified file. It is up to the client
to specify the correct X.spec.sum or X.strong.sum names.


R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/686b30e4cbf9b0ee536fb874847bf447695058d5

[Brian Wilkerson, 2016-02-23 00:27:01]

LGTM

https://codereview.chromium.org/1720963003/diff/1/pkg/analyzer_cli/lib/src/pa...
File pkg/analyzer_cli/lib/src/package_analyzer.dart (right):

https://codereview.chromium.org/1720963003/diff/1/pkg/analyzer_cli/lib/src/pa...
pkg/analyzer_cli/lib/src/package_analyzer.dart:177: class
InSummaryPackageUriResolver extends UriResolver {
I don't understand the need for either this class or InSummarySource. We should
talk offline.

https://codereview.chromium.org/1720963003/diff/1/pkg/analyzer_cli/lib/src/pa...
pkg/analyzer_cli/lib/src/package_analyzer.dart:315: SdkBundleBuilder sdkBundle =
new SdkBundleBuilder(
Probably ought to rename SdkBundleBuilder at some point if it's going to be used
for building packages too.

[Paul Berry, 2016-02-23 00:59:30]

lgtm.  I'm fine committing this as is, but let's talk tomorrow about the
question of single-package analysis mode--there are a couple of use cases that I
want to make sure get addressed.

https://codereview.chromium.org/1720963003/diff/1/pkg/analyzer_cli/lib/src/pa...
File pkg/analyzer_cli/lib/src/package_analyzer.dart (right):

https://codereview.chromium.org/1720963003/diff/1/pkg/analyzer_cli/lib/src/pa...
pkg/analyzer_cli/lib/src/package_analyzer.dart:123: bool compute(CacheEntry
entry, ResultDescriptor result) {
It looks like some of this code is duplicated from SdkSummaryResultProvider.  Is
it possible to share this code?

https://codereview.chromium.org/1720963003/diff/1/pkg/analyzer_cli/lib/src/pa...
pkg/analyzer_cli/lib/src/package_analyzer.dart:315: SdkBundleBuilder sdkBundle =
new SdkBundleBuilder(
On 2016/02/23 00:27:01, Brian Wilkerson wrote:
> Probably ought to rename SdkBundleBuilder at some point if it's going to be
used
> for building packages too.

Agreed.  I have some other changes I want to make to SdkBundle/SdkBundleBuilder
in a future CL, so I will do the rename at that time.

[scheglov, 2016-02-23 01:15:28]

Yes, we definitely need to discuss this tomorrow.

https://codereview.chromium.org/1720963003/diff/1/pkg/analyzer_cli/lib/src/pa...
File pkg/analyzer_cli/lib/src/package_analyzer.dart (right):

https://codereview.chromium.org/1720963003/diff/1/pkg/analyzer_cli/lib/src/pa...
pkg/analyzer_cli/lib/src/package_analyzer.dart:123: bool compute(CacheEntry
entry, ResultDescriptor result) {
On 2016/02/23 00:59:29, Paul Berry wrote:
> It looks like some of this code is duplicated from SdkSummaryResultProvider. 
Is
> it possible to share this code?

Yes, probably some of it can be shared.
I will address this in a future CL.

https://codereview.chromium.org/1720963003/diff/1/pkg/analyzer_cli/lib/src/pa...
pkg/analyzer_cli/lib/src/package_analyzer.dart:177: class
InSummaryPackageUriResolver extends UriResolver {
On 2016/02/23 00:27:01, Brian Wilkerson wrote:
> I don't understand the need for either this class or InSummarySource. We
should
> talk offline.

Yes, we did not get to this part offline today.

https://codereview.chromium.org/1720963003/diff/1/pkg/analyzer_cli/lib/src/pa...
pkg/analyzer_cli/lib/src/package_analyzer.dart:315: SdkBundleBuilder sdkBundle =
new SdkBundleBuilder(
On 2016/02/23 00:59:29, Paul Berry wrote:
> On 2016/02/23 00:27:01, Brian Wilkerson wrote:
> > Probably ought to rename SdkBundleBuilder at some point if it's going to be
> used
> > for building packages too.
> 
> Agreed.  I have some other changes I want to make to
SdkBundle/SdkBundleBuilder
> in a future CL, so I will do the rename at that time.

Yes, it was quite obvious that we need to rename it.
I just wanted to make some progress in the analysis and clean it up later.
Sure, Paul, make these changes.

[scheglov, 2016-02-23 01:19:09]

Description was changed from

==========
Initial hermetic package analyzer.

When --package-mode is specified, this turns ON the single package
analysis mode. My initial idea was to accept a single path - the root
folder of the package and analyze the package completely as Dart
Analysis Server does. But later I decided to accept a list of files
to analyze, at least for now.

We still need the --package-mode-path option with the path to the root
folder of the package because we need to know which libraries are in
the 'lib' folder and write these libraries into the output summary.

The option --package-name is used to write the same URIs into
summary as the clients are going to use to refer the package
libraries, and also as the package references itself.

Multiple --package-summary-input=pkg,summary options can be specified,
one for each package. Every referenced package (except itself) must
be listed.

If --package-summary-output is specified, the output summary of
the package is written to the specified file. It is up to the client
to specify the correct X.spec.sum or X.strong.sum names.


R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Initial hermetic package analyzer.

When --package-mode is specified, this turns ON the single package
analysis mode. My initial idea was to accept a single path - the root
folder of the package and analyze the package completely as Dart
Analysis Server does. But later I decided to accept a list of files
to analyze, at least for now.

We still need the --package-mode-path option with the path to the root
folder of the package because we need to know which libraries are in
the 'lib' folder and write these libraries into the output summary.

The option --package-name is used to write the same URIs into
summary as the clients are going to use to refer the package
libraries, and also as the package references itself.

Multiple --package-summary-input=pkg,summary options can be specified,
one for each package. Every referenced package (except itself) must
be listed.

If --package-summary-output is specified, the output summary of
the package is written to the specified file. It is up to the client
to specify the correct X.spec.sum or X.strong.sum names.


R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/686b30e4cbf9b0ee536fb874847bf447695058d5
==========

[scheglov, 2016-02-23 01:19:10]

Committed patchset #1 (id:1) manually as
686b30e4cbf9b0ee536fb874847bf447695058d5 (presubmit successful).