Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1720963002: Include glGetMultisamplefv API (Closed)

Created:
4 years, 10 months ago by Chris Dalton
Modified:
4 years, 10 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : debug prints #

Patch Set 3 : bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M include/gpu/GrCaps.h View 2 chunks +2 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLFunctions.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrCaps.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLDefines.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/gl/SkNullGLContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 31 (16 generated)
Chris Dalton
4 years, 10 months ago (2016-02-22 18:05:51 UTC) #3
bsalomon
lgtm
4 years, 10 months ago (2016-02-23 20:51:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720963002/1
4 years, 10 months ago (2016-02-23 21:02:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/69c1b24bcaa7cffd59753a75a7f3d155696fcac4
4 years, 10 months ago (2016-02-23 21:38:50 UTC) #9
ethannicholas
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1731333002/ by ethannicholas@google.com. ...
4 years, 10 months ago (2016-02-24 16:18:44 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720963002/1
4 years, 10 months ago (2016-02-24 17:45:37 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-24 17:46:45 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720963002/1
4 years, 10 months ago (2016-02-25 18:52:47 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-25 19:11:25 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720963002/20001
4 years, 10 months ago (2016-02-26 17:47:17 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720963002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720963002/40001
4 years, 10 months ago (2016-02-26 18:13:53 UTC) #23
Chris Dalton
Oops, stupid error on my part. I forgot to load glGetMultisamplefv when the context has ...
4 years, 10 months ago (2016-02-26 18:15:19 UTC) #24
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-26 18:34:25 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720963002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720963002/40001
4 years, 10 months ago (2016-02-26 18:38:40 UTC) #29
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 18:39:39 UTC) #31
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/eb79eea617d6d4ef6951206e51643ec4ef891920

Powered by Google App Engine
This is Rietveld 408576698