Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1720953002: allow move/zero-line/close to draw caps (Closed)

Created:
4 years, 10 months ago by caryclark
Modified:
4 years, 10 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : faster short-circuit to detect zero-length closed strokes #

Patch Set 3 : remove extra friend #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -4 lines) Patch
M include/core/SkPath.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkPath.cpp View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/core/SkStroke.cpp View 1 2 chunks +17 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720953002/1
4 years, 10 months ago (2016-02-22 17:57:19 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-22 18:28:51 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720953002/20001
4 years, 10 months ago (2016-02-22 18:43:00 UTC) #7
caryclark
4 years, 10 months ago (2016-02-22 18:43:31 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/6424)
4 years, 10 months ago (2016-02-22 18:44:01 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720953002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720953002/40001
4 years, 10 months ago (2016-02-22 19:03:37 UTC) #13
caryclark
Verified that only the test specific to this case in gm/path_stroke_with_zero_length.cpp is changed by this ...
4 years, 10 months ago (2016-02-22 19:14:37 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-22 19:32:17 UTC) #16
f(malita)
lgtm
4 years, 10 months ago (2016-02-22 20:08:23 UTC) #17
reed1
lgtm
4 years, 10 months ago (2016-02-22 20:39:21 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720953002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720953002/40001
4 years, 10 months ago (2016-02-22 20:44:00 UTC) #20
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 20:44:58 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d49a86ade0bab1fc3048d6ba5d8536abf25ed77c

Powered by Google App Engine
This is Rietveld 408576698