Issue 172093002: Fix Hydrogen bounds check elimination

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 172093002: Fix Hydrogen bounds check elimination (Closed)

Created:
6 years, 10 months ago by Jakob Kummerow

Modified:
6 years, 10 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fix Hydrogen bounds check elimination When combining bounds checks, they must all be moved before the first load/store that they are guarding. BUG=chromium:344186 LOG=y R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19475

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -93 lines)			Patch
	M	src/hydrogen-bce.cc	View		8 chunks	+65 lines, -93 lines	0 comments	Download
	A	test/mjsunit/regress/regress-crbug-344186.js	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Sven Panne

LGTM, although I have to admit that I have a hard time understanding all the ...

6 years, 10 months ago (2014-02-19 09:30:14 UTC) #1

Jakob Kummerow

6 years, 10 months ago (2014-02-19 10:30:46 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r19475 (presubmit successful).