gm/skbug_4868.cpp - Issue 1720863003: SkPDF: fix scalar serialization

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gm/skbug_4868.cpp

Issue 1720863003: SkPDF: fix scalar serialization (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: refactor, clean Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 /*

	2 * Copyright 2016 Google Inc.

	3 *

	4 * Use of this source code is governed by a BSD-style license that can be

	5 * found in the LICENSE file.

	6 */

	7

	8 #include "gm.h"

	9

	10 DEF_SIMPLE_GM(skbug_4868, canvas, 32, 32) {
	tomhudson 2016/02/24 20:10:56 It's pretty clear that there was misunderstanding It's pretty clear that there was misunderstanding in the bug; therefore, the bug # doesn't serve as sufficient documentation of your intent here. What was going wrong, and why? Why these particular scales? Why the weird clear() color?
	11 canvas->translate(-68.0f, -3378.0f);

	12 SkPaint paint;

	13 paint.setAntiAlias(true);

	14 paint.setStyle(SkPaint::kStroke_Style);

	15 canvas->scale(0.56692914f, 0.56692914f);

	16 SkRect rc = SkRect::MakeLTRB(158.0f, 5994.80273f, 165.0f, 5998.80225f);

	17 canvas->clipRect(rc);

	18 canvas->clear(0xFFCECFCE);

	19 canvas->drawLine(rc.left(), rc.top(), rc.right(), rc.bottom(), paint);

	20 canvas->drawLine(rc.right(), rc.top(), rc.left(), rc.bottom(), paint);

	21 }

OLD	NEW

« no previous file with comments | « no previous file | src/pdf/SkPDFUtils.h » ('j') | src/pdf/SkPDFUtils.h » ('J')