Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1720863002: Fix junit test runner script placement. (Closed)

Created:
4 years, 10 months ago by Torne
Modified:
4 years, 10 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix junit test runner script placement. In https://codereview.chromium.org/1708383002 the default placement of Java runner scripts was changed, but some cases where scripts should stay in the helper directory were missed, causing the tests to fail to run on the bots which still looked in helper/. Verified that these two are the only misplaced scripts listed in the build being extracted by the test bot. BUG= R=peter@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/5ac6fa949c5ab820b7289f8e9627a8466e684a95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M testing/android/junit/junit_test.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Torne
4 years, 10 months ago (2016-02-22 12:15:16 UTC) #2
Peter Beverloo
lgtm
4 years, 10 months ago (2016-02-22 12:18:59 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5ac6fa949c5ab820b7289f8e9627a8466e684a95 Cr-Commit-Position: refs/heads/master@{#376715}
4 years, 10 months ago (2016-02-22 12:22:42 UTC) #5
Torne
Committed patchset #1 (id:1) manually as 5ac6fa949c5ab820b7289f8e9627a8466e684a95 (presubmit successful).
4 years, 10 months ago (2016-02-22 12:23:07 UTC) #7
mikecase (-- gone --)
4 years, 10 months ago (2016-02-22 20:28:51 UTC) #8
Message was sent while issue was closed.
On 2016/02/22 at 12:23:07, torne wrote:
> Committed patchset #1 (id:1) manually as
5ac6fa949c5ab820b7289f8e9627a8466e684a95 (presubmit successful).

ahhhh, really sorry about this. Thanks for the fix.

Powered by Google App Engine
This is Rietveld 408576698