Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Side by Side Diff: third_party/WebKit/Source/core/svg/graphics/SVGImage.h

Issue 1720853002: Remove Image::computeIntrinsicDimensions() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-and-use-updateconcretesize-upload
Patch Set: Avoid using the size of the error image. Null-check in ImageResource saved the day in previous patc… Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Eric Seidel <eric@webkit.org> 2 * Copyright (C) 2006 Eric Seidel <eric@webkit.org>
3 * Copyright (C) 2009 Apple Inc. All rights reserved. 3 * Copyright (C) 2009 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 friend class AXLayoutObject; 87 friend class AXLayoutObject;
88 friend class SVGImageChromeClient; 88 friend class SVGImageChromeClient;
89 friend class SVGImageForContainer; 89 friend class SVGImageForContainer;
90 90
91 ~SVGImage() override; 91 ~SVGImage() override;
92 92
93 String filenameExtension() const override; 93 String filenameExtension() const override;
94 94
95 IntSize containerSize() const; 95 IntSize containerSize() const;
96 bool usesContainerSize() const override { return true; } 96 bool usesContainerSize() const override { return true; }
97 void computeIntrinsicDimensions(FloatSize& intrinsicSize, FloatSize& intrins icRatio) override;
98 97
99 bool dataChanged(bool allDataReceived) override; 98 bool dataChanged(bool allDataReceived) override;
100 99
101 // FIXME: SVGImages are underreporting decoded sizes and will be unable 100 // FIXME: SVGImages are underreporting decoded sizes and will be unable
102 // to prune because these functions are not implemented yet. 101 // to prune because these functions are not implemented yet.
103 void destroyDecodedData(bool) override { } 102 void destroyDecodedData(bool) override { }
104 103
105 // FIXME: Implement this to be less conservative. 104 // FIXME: Implement this to be less conservative.
106 bool currentFrameKnownToBeOpaque(MetadataMode = UseCurrentMetadata) override { return false; } 105 bool currentFrameKnownToBeOpaque(MetadataMode = UseCurrentMetadata) override { return false; }
107 106
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 m_image->setImageObserver(m_observer); 143 m_image->setImageObserver(m_observer);
145 } 144 }
146 private: 145 private:
147 Image* m_image; 146 Image* m_image;
148 RawPtrWillBeMember<ImageObserver> m_observer; 147 RawPtrWillBeMember<ImageObserver> m_observer;
149 }; 148 };
150 149
151 } // namespace blink 150 } // namespace blink
152 151
153 #endif // SVGImage_h 152 #endif // SVGImage_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698