Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/style/StylePendingImage.h

Issue 1720853002: Remove Image::computeIntrinsicDimensions() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-and-use-updateconcretesize-upload
Patch Set: Avoid using the size of the error image. Null-check in ImageResource saved the day in previous patc… Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 return nullptr; 56 return nullptr;
57 } 57 }
58 58
59 CSSImageValue* cssImageValue() const { return m_value->isImageValue() ? toCS SImageValue(m_value.get()) : 0; } 59 CSSImageValue* cssImageValue() const { return m_value->isImageValue() ? toCS SImageValue(m_value.get()) : 0; }
60 CSSImageGeneratorValue* cssImageGeneratorValue() const { return m_value->isI mageGeneratorValue() ? toCSSImageGeneratorValue(m_value.get()) : 0; } 60 CSSImageGeneratorValue* cssImageGeneratorValue() const { return m_value->isI mageGeneratorValue() ? toCSSImageGeneratorValue(m_value.get()) : 0; }
61 CSSCursorImageValue* cssCursorImageValue() const { return m_value->isCursorI mageValue() ? toCSSCursorImageValue(m_value.get()) : 0; } 61 CSSCursorImageValue* cssCursorImageValue() const { return m_value->isCursorI mageValue() ? toCSSCursorImageValue(m_value.get()) : 0; }
62 CSSImageSetValue* cssImageSetValue() const { return m_value->isImageSetValue () ? toCSSImageSetValue(m_value.get()) : 0; } 62 CSSImageSetValue* cssImageSetValue() const { return m_value->isImageSetValue () ? toCSSImageSetValue(m_value.get()) : 0; }
63 63
64 LayoutSize imageSize(const LayoutObject*, float /*multiplier*/, const Layout Size& /*defaultObjectSize*/) const override { return LayoutSize(); } 64 LayoutSize imageSize(const LayoutObject*, float /*multiplier*/, const Layout Size& /*defaultObjectSize*/) const override { return LayoutSize(); }
65 bool imageHasRelativeSize() const override { return false; } 65 bool imageHasRelativeSize() const override { return false; }
66 void computeIntrinsicDimensions(const LayoutObject*, FloatSize& /* intrinsic Size */, FloatSize& /* intrinsicRatio */) override { }
67 bool usesImageContainerSize() const override { return false; } 66 bool usesImageContainerSize() const override { return false; }
68 void addClient(LayoutObject*) override { } 67 void addClient(LayoutObject*) override { }
69 void removeClient(LayoutObject*) override { } 68 void removeClient(LayoutObject*) override { }
70 PassRefPtr<Image> image(const LayoutObject*, const IntSize&, float) const ov erride 69 PassRefPtr<Image> image(const LayoutObject*, const IntSize&, float) const ov erride
71 { 70 {
72 ASSERT_NOT_REACHED(); 71 ASSERT_NOT_REACHED();
73 return nullptr; 72 return nullptr;
74 } 73 }
75 bool knownToBeOpaque(const LayoutObject*) const override { return false; } 74 bool knownToBeOpaque(const LayoutObject*) const override { return false; }
76 75
(...skipping 12 matching lines...) Expand all
89 88
90 // TODO(sashab): Replace this with <const CSSValue> once RefPtrWillBeMember< > 89 // TODO(sashab): Replace this with <const CSSValue> once RefPtrWillBeMember< >
91 // supports const types. 90 // supports const types.
92 RefPtrWillBeMember<CSSValue> m_value; 91 RefPtrWillBeMember<CSSValue> m_value;
93 }; 92 };
94 93
95 DEFINE_STYLE_IMAGE_TYPE_CASTS(StylePendingImage, isPendingImage()); 94 DEFINE_STYLE_IMAGE_TYPE_CASTS(StylePendingImage, isPendingImage());
96 95
97 } // namespace blink 96 } // namespace blink
98 #endif 97 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698