third_party/WebKit/LayoutTests/svg/custom/svg-image-par-none-no-intrinsic-size.html - Issue 1720853002: Remove Image::computeIntrinsicDimensions()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/custom/svg-image-par-none-no-intrinsic-size.html

Issue 1720853002: Remove Image::computeIntrinsicDimensions() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-and-use-updateconcretesize-upload

Patch Set: Avoid using the size of the error image. Null-check in ImageResource saved the day in previous patc… Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/svg/custom/svg-image-par-none-no-intrinsic-size-expected.html » ('j') | third_party/WebKit/Source/platform/graphics/GeneratedImage.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <svg width="100" height="200" style="background-color: red">	2 <svg width="100" height="200" style="background-color: red">

3 <image width="100" height="200" preserveAspectRatio="none"	3 <image width="100" height="200" preserveAspectRatio="none"

4 xlink:href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 100 200'><rect width='100' height='200' fill='green'/></svg>"/>	4 xlink:href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 100 200'><rect width='100' height='200' fill='green'/></svg>"/>

5 </svg>	5 </svg>

	6 <svg width="100" height="200">

	7 <image width="100" height="200" preserveAspectRatio="none"

	8 xlink:href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' vie wBox='0 0 100 100'><circle r='50' cx='50' cy='50' fill='green'/></svg>"/>

	9 </svg>

OLD	NEW