Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 172083003: SSE2 implementation of S32_D565_Opaque (Closed)

Created:
6 years, 10 months ago by qiankun
Modified:
6 years, 10 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

SSE2 implementation of S32_D565_Opaque Benchmarks hitting this path can benfit from this patch. Here are the data: before after gradient_radial2_mirror 10885.52 10849.48 0.33% gradient_radial2_clamp_hicolor 11819.69 11644.83 1.48% gradient_radial2_clamp 11816.10 11649.91 1.41% bitmaprect_FF_filter_trans 6.27 4.88 22.17% bitmaprect_FF_nofilter_trans 6.27 4.88 22.17% bitmaprect_FF_filter_identity 6.31 4.86 22.98% bitmaprect_FF_nofilter_identity 6.25 4.86 22.24% bitmap_4444_update 6.26 5.05 19.33% bitmap_4444_update_volatile 6.21 5.06 18.52% bitmap_4444 6.22 5.06 18.65% BUG= Committed: http://code.google.com/p/skia/source/detail?r=13556

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -1 line) Patch
M src/opts/SkBlitRow_opts_SSE2.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/opts/SkBlitRow_opts_SSE2.cpp View 1 chunk +77 lines, -0 lines 0 comments Download
M src/opts/opts_check_SSE2.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
qiankun
PTAL, thanks:)
6 years, 10 months ago (2014-02-19 09:10:41 UTC) #1
mtklein
On 2014/02/19 09:10:41, qiankun wrote: > PTAL, thanks:) lgtm Things sure are easy when you ...
6 years, 10 months ago (2014-02-21 17:11:09 UTC) #2
qiankun
The CQ bit was checked by qiankun.miao@intel.com
6 years, 10 months ago (2014-02-24 04:09:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/qiankun.miao@intel.com/172083003/1
6 years, 10 months ago (2014-02-24 04:10:08 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-24 04:23:41 UTC) #5
Message was sent while issue was closed.
Change committed as 13556

Powered by Google App Engine
This is Rietveld 408576698