Run update_use_counter_css.py for r376249, r376148 and r376051.

Run update_use_counter_css.py for r376249, r376148 and r376051.

R=holte@chromium.org

Committed: https://crrev.com/d98e28aaa200cad39efcd16f83387f866d8e31fb
Cr-Commit-Position: refs/heads/master@{#376787}

[mstensho (USE GERRIT), 2016-02-22 10:35:13]

First tried to run pretty_print.py after update_use_counter_css.py, because
presumbit failed:

** Presubmit ERRORS **
histograms.xml is not formatted correctly; run pretty_print.py to fix

That resulted in these additional changes:

@@ -47053,20 +47053,20 @@ http://cs/file:chrome/histograms.xml - but prefer this
file for new entries.
   </summary>
 </histogram>
 
-<histogram name="SiteEngagementService.ScoreDecayedTo">
+<histogram name="SiteEngagementService.ScoreDecayedFrom">
   <owner>calamity@chromium.org</owner>
   <owner>dominickn@chromium.org</owner>
   <summary>
-    The site engagement score of an origin once decay has occured. Recorded at
+    The site engagement score of an origin prior to applying decay. Recorded at
     the first engagement event after decay, independently per decay event.
   </summary>
 </histogram>
 
-<histogram name="SiteEngagementService.ScoreDecayedFrom">
+<histogram name="SiteEngagementService.ScoreDecayedTo">
   <owner>calamity@chromium.org</owner>
   <owner>dominickn@chromium.org</owner>
   <summary>
-    The site engagement score of an origin prior to applying decay. Recorded at
+    The site engagement score of an origin once decay has occured. Recorded at
     the first engagement event after decay, independently per decay event.
   </summary>
 </histogram>

Then I retried to upload the CL:

Running presubmit upload checks ...
INFO:root:Loading histograms.xml...
INFO:root:histograms.xml is correctly pretty-printed.
ERROR:root:Duplicate histogram definition SiteEngagementService.ScoreDecayedFrom
ERROR:root:Duplicate histogram definition SiteEngagementService.ScoreDecayedTo
ERROR:root:Error parsing
/opt/opera/chr/work/src/tools/metrics/histograms/histograms.xml
Traceback (most recent call last):
  File "validate_format.py", line 23, in <module>
    main()
  File "validate_format.py", line 19, in main
    histograms = extract_histograms.ExtractHistograms(xml_file)
  File "/opt/opera/chr/work/src/tools/metrics/histograms/extract_histograms.py",
line 482, in ExtractHistograms
    raise Error()
extract_histograms.Error

** Presubmit ERRORS **
histograms.xml is not well formatted; run validate_format.py and fix the
reported errors

Presubmit checks took 7.1s to calculate.


So I backed out the changes from pretty_print.py again.
Better have some knowledgeable human look at this.

[Steven Holte, 2016-02-22 18:45:40]

On 2016/02/22 10:35:13, mstensho wrote:
> First tried to run pretty_print.py after update_use_counter_css.py, because
> presumbit failed:
> 
> ** Presubmit ERRORS **
> histograms.xml is not formatted correctly; run pretty_print.py to fix
> 
> That resulted in these additional changes:
> 
> @@ -47053,20 +47053,20 @@ http://cs/file:chrome/histograms.xml - but prefer
this
> file for new entries.
>    </summary>
>  </histogram>
>  
> -<histogram name="SiteEngagementService.ScoreDecayedTo">
> +<histogram name="SiteEngagementService.ScoreDecayedFrom">
>    <mailto:owner>calamity@chromium.org</owner>
>    <mailto:owner>dominickn@chromium.org</owner>
>    <summary>
> -    The site engagement score of an origin once decay has occured. Recorded
at
> +    The site engagement score of an origin prior to applying decay. Recorded
at
>      the first engagement event after decay, independently per decay event.
>    </summary>
>  </histogram>
>  
> -<histogram name="SiteEngagementService.ScoreDecayedFrom">
> +<histogram name="SiteEngagementService.ScoreDecayedTo">
>    <mailto:owner>calamity@chromium.org</owner>
>    <mailto:owner>dominickn@chromium.org</owner>
>    <summary>
> -    The site engagement score of an origin prior to applying decay. Recorded
at
> +    The site engagement score of an origin once decay has occured. Recorded
at
>      the first engagement event after decay, independently per decay event.
>    </summary>
>  </histogram>
> 
> Then I retried to upload the CL:
> 
> Running presubmit upload checks ...
> INFO:root:Loading histograms.xml...
> INFO:root:histograms.xml is correctly pretty-printed.
> ERROR:root:Duplicate histogram definition
SiteEngagementService.ScoreDecayedFrom
> ERROR:root:Duplicate histogram definition SiteEngagementService.ScoreDecayedTo
> ERROR:root:Error parsing
> /opt/opera/chr/work/src/tools/metrics/histograms/histograms.xml
> Traceback (most recent call last):
>   File "validate_format.py", line 23, in <module>
>     main()
>   File "validate_format.py", line 19, in main
>     histograms = extract_histograms.ExtractHistograms(xml_file)
>   File
"/opt/opera/chr/work/src/tools/metrics/histograms/extract_histograms.py",
> line 482, in ExtractHistograms
>     raise Error()
> extract_histograms.Error
> 
> ** Presubmit ERRORS **
> histograms.xml is not well formatted; run validate_format.py and fix the
> reported errors
> 
> Presubmit checks took 7.1s to calculate.
> 
> 
> So I backed out the changes from pretty_print.py again.
> Better have some knowledgeable human look at this.

It looks like the histograms that had pretty print errors got reverted here:
832dc593ecbd3c29068ccd5777fc295b8d19e0de

lgtm

[mstensho (USE GERRIT), 2016-02-22 18:50:36]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-02-22 18:51:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1720823002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1720823002/1

[commit-bot: I haz the power, 2016-02-22 20:11:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-22 20:12:51]

Description was changed from

==========
Run update_use_counter_css.py for r376249, r376148 and r376051.

R=holte@chromium.org
==========

to

==========
Run update_use_counter_css.py for r376249, r376148 and r376051.

R=holte@chromium.org

Committed: https://crrev.com/d98e28aaa200cad39efcd16f83387f866d8e31fb
Cr-Commit-Position: refs/heads/master@{#376787}
==========

[commit-bot: I haz the power, 2016-02-22 20:12:51]

Patchset 1 (id:??) landed as
https://crrev.com/d98e28aaa200cad39efcd16f83387f866d8e31fb
Cr-Commit-Position: refs/heads/master@{#376787}