Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1720813002: Remove ContentShellOnAndroid from status files (Closed)

Created:
4 years, 10 months ago by Bill Hesse
Modified:
4 years, 10 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove ContentShellOnAndroid from status files Dartium and content_shell are no longer built or tested on Android. A separate issue is filed to remove support from the test scripts: https://github.com/dart-lang/sdk/issues/25832 BUG= R=ricow@google.com Committed: https://github.com/dart-lang/sdk/commit/270ad3f5521ad0b63a220c77f5663a6d19e0d5fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -451 lines) Patch
M pkg/pkg.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dartium.status View 32 chunks +343 lines, -405 lines 0 comments Download
M tests/corelib/corelib.status View 3 chunks +3 lines, -6 lines 0 comments Download
M tests/html/html.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate.status View 2 chunks +2 lines, -13 lines 0 comments Download
M tests/language/language.status View 3 chunks +4 lines, -7 lines 0 comments Download
M tests/lib/lib.status View 3 chunks +2 lines, -11 lines 0 comments Download
M tests/standalone/standalone.status View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/utils/utils.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
co19-dartium.status file also has duplicate sections combined and sorted.
4 years, 10 months ago (2016-02-22 09:12:26 UTC) #2
ricow1
lgtm
4 years, 10 months ago (2016-02-22 09:19:53 UTC) #3
Bill Hesse
4 years, 10 months ago (2016-02-22 09:20:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
270ad3f5521ad0b63a220c77f5663a6d19e0d5fd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698