src/wasm/asm-wasm-builder.cc - Issue 1720773002: Allow bitwise-or aside from type annotations in asm->wasm conversion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/asm-wasm-builder.cc

Issue 1720773002: Allow bitwise-or aside from type annotations in asm->wasm conversion. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/wasm/asm-wasm-builder.cc

diff --git a/src/wasm/asm-wasm-builder.cc b/src/wasm/asm-wasm-builder.cc

index 49b6e0cf7cbdfef8dd72f4f5e1a446c2ec5534a6..ee5427b174d11e8736ca08af45e605e55f3ca8ab 100644

--- a/src/wasm/asm-wasm-builder.cc

+++ b/src/wasm/asm-wasm-builder.cc

@@ -874,7 +874,6 @@ class AsmWasmBuilderImpl : public AstVisitor {

(TypeOf(expr->left()) == kAstI32)) {

return kAsIs;

} else {

- UNREACHABLE();

return kNone;

}

« no previous file with comments | « no previous file | test/mjsunit/wasm/asm-wasm.js » ('j') | no next file with comments »