Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 1720773002: Allow bitwise-or aside from type annotations in asm->wasm conversion. (Closed)

Created:
4 years, 10 months ago by bradnelson
Modified:
4 years, 10 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow bitwise-or aside from type annotations in asm->wasm conversion. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm R=aseemgarg@chromium.org,titzer@chromium.org LOG=N Committed: https://crrev.com/37fc16ece4b1a224569ea6092c7edab4c692e148 Cr-Commit-Position: refs/heads/master@{#34185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1 line) Patch
M src/wasm/asm-wasm-builder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
bradnelson
Had this on sundry branches for a bit, keep forget to send out. PTAL
4 years, 10 months ago (2016-02-22 01:55:49 UTC) #2
titzer
lgtm
4 years, 10 months ago (2016-02-22 05:48:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720773002/1
4 years, 10 months ago (2016-02-22 05:54:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-22 05:55:32 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 05:56:30 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37fc16ece4b1a224569ea6092c7edab4c692e148
Cr-Commit-Position: refs/heads/master@{#34185}

Powered by Google App Engine
This is Rietveld 408576698