Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Issue 1720763002: Run most of the tests on "Win x64 GN" that "Win7 x64 Tests (1)" does. (Closed)

Created:
4 years, 10 months ago by Dirk Pranke
Modified:
4 years, 10 months ago
Reviewers:
Nico, brucedawson
CC:
chromium-reviews, Will Harris, brettw, jschuh, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run most of the tests on "Win x64 GN" that "Win7 x64 Tests (1)" does. This CL adds a bunch of test steps to the "Win x64 GN" bot so that we mirror the list that we run on the GYP bot (achieving test parity). It is unfortunate that we can only accomplish this via copy/paste. Tests not yet being run: - message_center_unittests (lots of failures, not yet triaged). - browser_tests is being run locally, not under swarming (one test fails under swarming, not sure why yet). - script_tests and isolate_tests (will add in a follow-up CL so I can stare at the way isolates work a little better for these). This is being done as part of the build-up to flipping the win_chromium_x64_rel_ng bot to mirror the GN bot and thus get win x64 coverage of the GN build in the CQ. R=brucedawson@chromium.org, thakis@chromium.org BUG=581899, 486089, 354261 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_chromium_gn_x64_rel Committed: https://crrev.com/79ada9d50ffc7e670aad99a8a6709de7474f762c Cr-Commit-Position: refs/heads/master@{#377158}

Patch Set 1 #

Patch Set 2 : merge to #376672 #

Patch Set 3 : add missing message_center_unittests test type #

Patch Set 4 : merge in mb debugging changes, drop script tests for the moment #

Patch Set 5 : drop out message_center_unittests #

Patch Set 6 : turn off swarming for browser_tests temporarily #

Patch Set 7 : merge to #376900 #

Patch Set 8 : remove browser_tests altogether #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -1 line) Patch
M testing/buildbot/chromium.win.json View 1 2 3 4 5 6 7 1 chunk +355 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/mb/mb_config.pyl View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Dirk Pranke
4 years, 10 months ago (2016-02-23 01:59:34 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720763002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720763002/80001
4 years, 10 months ago (2016-02-23 02:00:05 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/25489) android_chromium_gn_compile_rel on ...
4 years, 10 months ago (2016-02-23 02:04:58 UTC) #7
Nico
lgtm
4 years, 10 months ago (2016-02-23 15:39:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720763002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720763002/120001
4 years, 10 months ago (2016-02-23 22:01:16 UTC) #11
commit-bot: I haz the power
Committed patchset #8 (id:120001)
4 years, 10 months ago (2016-02-24 00:51:54 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 00:53:11 UTC) #15
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/79ada9d50ffc7e670aad99a8a6709de7474f762c
Cr-Commit-Position: refs/heads/master@{#377158}

Powered by Google App Engine
This is Rietveld 408576698