Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1720743006: Add mac_optional_gpu_tests_rel bots to gpu related CLs. (Closed)

Created:
4 years, 10 months ago by Zhenyao Mo
Modified:
4 years, 10 months ago
CC:
chromium-reviews, blink-reviews, piman+watch_chromium.org, Jamie Madill, Geoff Lang, Corentin Wallez
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mac_optional_gpu_tests_rel bots to gpu related CLs. BUG= TEST=CLs in gpu/ or third_party/WebKit/Source/module/webgl R=kbr@chromium.org TBR=sievers@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/fb33cbfb3b32a97bc0a152e57b4baedd98f5a07f Cr-Commit-Position: refs/heads/master@{#376874}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M gpu/PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/roll_webgl_conformance.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Zhenyao Mo
Great. This CL is testing itself! kbr: PTAL
4 years, 10 months ago (2016-02-22 23:12:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720743006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720743006/1
4 years, 10 months ago (2016-02-22 23:15:00 UTC) #4
Ken Russell (switch to Gerrit)
That's awesome! :) LGTM +jmadill,geofflang,cwallez as FYI. Should we add linux_optional_gpu_tests_rel too (in a follow-up ...
4 years, 10 months ago (2016-02-22 23:17:05 UTC) #5
Jamie Madill
Awesome! :) Ken I'm not sure if you heard, but there was some issue causing ...
4 years, 10 months ago (2016-02-23 00:18:18 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-23 00:22:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720743006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720743006/1
4 years, 10 months ago (2016-02-23 00:31:15 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 00:41:43 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 00:42:40 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb33cbfb3b32a97bc0a152e57b4baedd98f5a07f
Cr-Commit-Position: refs/heads/master@{#376874}

Powered by Google App Engine
This is Rietveld 408576698