Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: tools/dom/scripts/htmlrenamer.py

Issue 1720743005: Generation of sdk/lib files from 45 roll (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Merged with TOT Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/scripts/htmldartgenerator.py ('k') | tools/dom/scripts/idlnode.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/htmlrenamer.py
diff --git a/tools/dom/scripts/htmlrenamer.py b/tools/dom/scripts/htmlrenamer.py
index 823666cfb62016372cf473d03e389eb17f932481..b525b6adb98451926c2466a83b31b93759339dc8 100644
--- a/tools/dom/scripts/htmlrenamer.py
+++ b/tools/dom/scripts/htmlrenamer.py
@@ -136,6 +136,7 @@ _removed_html_interfaces = [
'WebKitMediaSource',
'WebKitNotification',
'WebGLRenderingContextBase',
+ 'WebGL2RenderingContextBase',
'WebKitSourceBuffer',
'WebKitSourceBufferList',
'WorkerLocation', # Workers
@@ -177,9 +178,19 @@ convert_to_future_members = monitored.Set(
# constructor for dispatch purposes.
custom_html_constructors = monitored.Set(
'htmlrenamer.custom_html_constructors', [
+ 'CompositionEvent', # 45 Roll hide default constructor use Dart's custom
+ 'CustomEvent', # 45 Roll hide default constructor use Dart's custom
+ 'Event', # 45 Roll hide default constructor use Dart's custom
+ 'HashChangeEvent', # 45 Roll hide default constructor use Dart's custom
'HTMLAudioElement',
'HTMLOptionElement',
+ 'KeyboardEvent', # 45 Roll hide default constructor use Dart's custom
+ 'MessageEvent', # 45 Roll hide default constructor use Dart's custom
+ 'MouseEvent', # 45 Roll hide default constructor use Dart's custom
'MutationObserver',
+ 'StorageEvent', # 45 Roll hide default constructor use Dart's custom
+ 'UIEvent', # 45 Roll hide default constructor use Dart's custom
+ 'WheelEvent', # 45 Roll hide default constructor use Dart's custom
])
# Members from the standard dom that should not be exposed publicly in dart:html
@@ -253,14 +264,6 @@ private_html_members = monitored.Set('htmlrenamer.private_html_members', [
'Element.querySelectorAll',
# TODO(vsm): These have been converted from int to double in Chrome 36.
# Special case them so we run on 34, 35, and 36.
- 'Element.offsetLeft',
- 'Element.offsetTop',
- 'Element.offsetWidth',
- 'Element.offsetHeight',
- 'Element.clientLeft',
- 'Element.clientTop',
- 'Element.clientWidth',
- 'Element.clientHeight',
'Element.scrollLeft',
'Element.scrollTop',
'Element.scrollWidth',
@@ -404,6 +407,7 @@ private_html_members = monitored.Set('htmlrenamer.private_html_members', [
# Members from the standard dom that exist in the dart:html library with
# identical functionality but with cleaner names.
renamed_html_members = monitored.Dict('htmlrenamer.renamed_html_members', {
+ 'ConsoleBase.assert': 'assertCondition',
'CSSKeyframesRule.insertRule': 'appendRule',
'DirectoryEntry.getDirectory': '_getDirectory',
'DirectoryEntry.getFile': '_getFile',
@@ -434,8 +438,6 @@ renamed_overloads = monitored.Dict('htmldartgenerator.renamed_overloads', {
'AudioContext.createBuffer(ArrayBuffer buffer, boolean mixToMono)':
'createBufferFromBuffer',
'CSS.supports(DOMString conditionText)': 'supportsCondition',
- 'CanvasRenderingContext2D.createPattern(HTMLImageElement image, '
- 'DOMString repetitionType)': 'createPatternFromImage',
'DataTransferItemList.add(File file)': 'addFile',
'DataTransferItemList.add(DOMString data, DOMString type)': 'addData',
'FormData.append(DOMString name, Blob value, DOMString filename)':
@@ -486,7 +488,11 @@ renamed_overloads = monitored.Dict('htmldartgenerator.renamed_overloads', {
'WebSocket.send(ArrayBuffer data)': 'sendByteBuffer',
'WebSocket.send(ArrayBufferView data)': 'sendTypedData',
'WebSocket.send(DOMString data)': 'sendString',
- 'WebSocket.send(Blob data)': 'sendBlob'
+ 'WebSocket.send(Blob data)': 'sendBlob',
+ 'Window.setInterval(DOMString handler, long timeout, any arguments)': '_setInterval_String',
+ 'Window.setTimeout(DOMString handler, long timeout, any arguments)': '_setTimeout_String',
+ 'WindowTimers.setInterval(DOMString handler, long timeout, any arguments)': '_setInterval_String',
+ 'WindowTimers.setTimeout(DOMString handler, long timeout, any arguments)': '_setTimeout_String',
})
# Members that have multiple definitions, but their types are identical (only
@@ -553,7 +559,10 @@ removed_html_members = monitored.Set('htmlrenamer.removed_html_members', [
'CanvasRenderingContext2D.setMiterLimit',
'CanvasRenderingContext2D.setShadow',
'CanvasRenderingContext2D.setStrokeColor',
+ # Disable the webKit version, imageSmoothingEnabled is exposed.
+ 'CanvasRenderingContext2D.webkitImageSmoothingEnabled',
'CharacterData.remove',
+ 'ChildNode.replaceWith',
'Window.call:blur',
'Window.call:focus',
'Window.clientInformation',
@@ -570,6 +579,7 @@ removed_html_members = monitored.Set('htmlrenamer.removed_html_members', [
'Window.webkitRequestAnimationFrame',
'Document.alinkColor',
'Document.all',
+ 'Document.append',
'Document.applets',
'Document.bgColor',
'Document.clear',
@@ -605,6 +615,7 @@ removed_html_members = monitored.Set('htmlrenamer.removed_html_members', [
'Document.location',
'Document.on:wheel',
'Document.open',
+ 'Document.prepend',
'Document.register',
'Document.set:domain',
'Document.vlinkColor',
@@ -643,14 +654,24 @@ removed_html_members = monitored.Set('htmlrenamer.removed_html_members', [
'DOMException.VALIDATION_ERR',
'DOMException.WRONG_DOCUMENT_ERR',
'Element.accessKey',
+ 'Element.append',
'Element.dataset',
'Element.get:classList',
'Element.getAttributeNode',
'Element.getAttributeNodeNS',
'Element.getElementsByTagNameNS',
'Element.innerText',
+ # TODO(terry): All offset* attributes are in both HTMLElement and Element
+ # (it's a Chrome bug with a FIXME note to correct - sometime).
+ # Until corrected these Element attributes must be ignored.
+ 'Element.offsetParent',
+ 'Element.offsetTop',
+ 'Element.offsetLeft',
+ 'Element.offsetWidth',
+ 'Element.offsetHeight',
'Element.on:wheel',
'Element.outerText',
+ 'Element.prepend',
'Element.removeAttributeNode',
'Element.set:outerHTML',
'Element.setAttributeNode',
@@ -804,6 +825,8 @@ removed_html_members = monitored.Set('htmlrenamer.removed_html_members', [
'NodeIterator.expandEntityReferences',
'NodeIterator.filter',
'NodeList.item',
+ 'ParentNode.append',
+ 'ParentNode.prepend',
'Performance.webkitClearMarks',
'Performance.webkitClearMeasures',
'Performance.webkitGetEntries',
@@ -817,6 +840,7 @@ removed_html_members = monitored.Set('htmlrenamer.removed_html_members', [
'Touch.get:webkitRadiusX',
'Touch.get:webkitRadiusY',
'Touch.get:webkitForce',
+ 'Touch.get:webkitRotationAngle',
'WheelEvent.wheelDelta',
'WheelEvent.wheelDeltaX',
'WheelEvent.wheelDeltaY',
@@ -869,6 +893,8 @@ class HtmlRenamer(object):
return html_interface_renames[interface_id]
return None;
+ def isPrivate(self, interface, member):
+ return self._FindMatch(interface, member, '', private_html_members)
def RenameMember(self, interface_name, member_node, member, member_prefix='',
dartify_name=True):
« no previous file with comments | « tools/dom/scripts/htmldartgenerator.py ('k') | tools/dom/scripts/idlnode.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698