Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: tools/dom/scripts/htmldartgenerator.py

Issue 1720743005: Generation of sdk/lib files from 45 roll (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Merged with TOT Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/scripts/generator.py ('k') | tools/dom/scripts/htmlrenamer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/htmldartgenerator.py
diff --git a/tools/dom/scripts/htmldartgenerator.py b/tools/dom/scripts/htmldartgenerator.py
index b93b0ca9ebdd905b1c1b8a5cd2365bbab33a7084..c944fc3e99e9ea11ac064f3078d5807e8e2b14ed 100644
--- a/tools/dom/scripts/htmldartgenerator.py
+++ b/tools/dom/scripts/htmldartgenerator.py
@@ -132,6 +132,13 @@ class HtmlDartGenerator(object):
secondary_parents = self._database.TransitiveSecondaryParents(interface,
not self._dart_use_blink)
+ remove_duplicate_parents = list(set(secondary_parents))
+ if len(secondary_parents) != len(remove_duplicate_parents):
+ secondary_parents = remove_duplicate_parents
+ parent_list = ", ".join([" %s" % (parent.id) for parent in secondary_parents])
+ _logger.warn('Interface %s has duplicate parent interfaces %s - ' \
+ 'ignoring duplicates. Please file a bug with the dart:html team.' % (interface.id, parent_list))
+
for parent_interface in sorted(secondary_parents):
if isinstance(parent_interface, str):
continue
« no previous file with comments | « tools/dom/scripts/generator.py ('k') | tools/dom/scripts/htmlrenamer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698