tools/dom/scripts/dartmetadata.py - Issue 1720743005: Generation of sdk/lib files from 45 roll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/dartmetadata.py

Issue 1720743005: Generation of sdk/lib files from 45 roll (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Merged with TOT Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/scripts/dartmetadata.py

diff --git a/tools/dom/scripts/dartmetadata.py b/tools/dom/scripts/dartmetadata.py

index e0d28aba27dc5f30bbf748b7788bd85c641dedf7..3e16cf72d5f19a4a2474403f02bf2812f5b81567 100644

--- a/tools/dom/scripts/dartmetadata.py

+++ b/tools/dom/scripts/dartmetadata.py

@@ -126,13 +126,13 @@ _dart2js_annotations = monitored.Dict('dartmetadata._dart2js_annotations', {

# addEventListener on the target, so we avoid

'Event.currentTarget': [

"@Creates('Null')",

- "@Returns('EventTarget|=Object|Null')",

+ "@Returns('EventTarget|=Object')",

# Only nodes in the DOM bubble and have target !== currentTarget.

'Event.target': [

"@Creates('Node')",

- "@Returns('EventTarget|=Object|Null')",

+ "@Returns('EventTarget|=Object')",

'File.lastModifiedDate': [

@@ -273,7 +273,7 @@ _dart2js_annotations = monitored.Dict('dartmetadata._dart2js_annotations', {

'MouseEvent.relatedTarget': [

"@Creates('Node')",

- "@Returns('EventTarget|=Object|Null')",

+ "@Returns('EventTarget|=Object')",

'PopStateEvent.state': [

« no previous file with comments | « tools/dom/scripts/dartgenerator.py ('k') | tools/dom/scripts/generate_blink_file.py » ('j') | no next file with comments »