Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3849)

Unified Diff: chrome/browser/download/download_file.h

Issue 172074: Show or open downloaded items on the UI thread for Mac (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/download/download_file.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_file.h
===================================================================
--- chrome/browser/download/download_file.h (revision 23654)
+++ chrome/browser/download/download_file.h (working copy)
@@ -201,12 +201,18 @@
void RemoveDownloadManager(DownloadManager* manager);
void RemoveDownload(int id, DownloadManager* manager);
+#if !defined(OS_MACOSX)
+ // The open and show methods run on the file thread, which does not work on
+ // Mac OS X (which uses the UI thread for opens).
+
// Handler for shell operations sent from the UI to the download thread.
void OnShowDownloadInShell(const FilePath& full_path);
+
// Handler to open or execute a downloaded file.
void OnOpenDownloadInShell(const FilePath& full_path,
const GURL& url,
gfx::NativeView parent_window);
+#endif
// The download manager has provided a final name for a download. Sent from
// the UI thread and run on the download thread.
« no previous file with comments | « no previous file | chrome/browser/download/download_file.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698