content/common/sandbox_win.cc - Issue 1720643002: [Win10 sandbox mitigations] MITIGATION_NONSYSTEM_FONT_DISABLE adjustment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/sandbox_win.cc

Issue 1720643002: [Win10 sandbox mitigations] MITIGATION_NONSYSTEM_FONT_DISABLE adjustment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review changes, part 1. Only enable for DirectWrite. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/sandbox_win.cc

diff --git a/content/common/sandbox_win.cc b/content/common/sandbox_win.cc

index 29fb55713db92c563a4ca2a723682e108769efdf..8ca352384c748ec6fe5f5ec7bf9d0ae4a2aa59dc 100644

--- a/content/common/sandbox_win.cc

+++ b/content/common/sandbox_win.cc

@@ -700,9 +700,13 @@ base::Process StartSandboxedProcess(

sandbox::MITIGATION_DEP |

sandbox::MITIGATION_DEP_NO_ATL_THUNK |

sandbox::MITIGATION_SEHOP |

- sandbox::MITIGATION_NONSYSTEM_FONT_DISABLE |

sandbox::MITIGATION_IMAGE_LOAD_NO_REMOTE |

sandbox::MITIGATION_IMAGE_LOAD_NO_LOW_LABEL;

+#if !defined(NACL_WIN64)

+ // Only enable for DirectWrite, not GDI.

+ if (gfx::win::ShouldUseDirectWrite())

+ mitigations |= sandbox::MITIGATION_NONSYSTEM_FONT_DISABLE;

+#endif

Will Harris 2016/02/23 05:46:02 for the NACL_WIN64 case, I think we can always ena

penny 2016/02/23 21:24:56 Done.

if (policy->SetProcessMitigations(mitigations) != sandbox::SBOX_ALL_OK)

return base::Process();

« no previous file with comments | « no previous file | no next file » | no next file with comments »