Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: content/common/frame_messages.h

Issue 172063002: Unify frame IDs with RenderFrameHost routing IDs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix type Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/test/mock_render_thread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/frame_messages.h
diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h
index 03471701ca785efa756754b416d694cd7ff40c2a..9e07965ac0a11f0098fdf4d656571a5629f751eb 100644
--- a/content/common/frame_messages.h
+++ b/content/common/frame_messages.h
@@ -292,27 +292,18 @@ IPC_MESSAGE_ROUTED1(FrameMsg_Navigate, FrameMsg_Navigate_Params)
// -----------------------------------------------------------------------------
// Messages sent from the renderer to the browser.
-// Sent by the renderer when a child frame is created in the renderer. The
-// |parent_frame_id| and |frame_id| are NOT routing ids. They are
-// renderer-allocated identifiers used for tracking a frame's creation.
+// Sent by the renderer when a child frame is created in the renderer.
//
// Each of these messages will have a corresponding FrameHostMsg_Detach message
// sent when the frame is detached from the DOM.
-//
-// TOOD(ajwong): replace parent_render_frame_id and frame_id with just the
-// routing ids.
-IPC_SYNC_MESSAGE_CONTROL4_1(FrameHostMsg_CreateChildFrame,
- int32 /* parent_render_frame_id */,
- int64 /* parent_frame_id */,
- int64 /* frame_id */,
+IPC_SYNC_MESSAGE_CONTROL2_1(FrameHostMsg_CreateChildFrame,
+ int32 /* parent_routing_id */,
std::string /* frame_name */,
- int /* new_render_frame_id */)
+ int32 /* new_routing_id */)
// Sent by the renderer to the parent RenderFrameHost when a child frame is
// detached from the DOM.
-IPC_MESSAGE_ROUTED2(FrameHostMsg_Detach,
- int64 /* parent_frame_id */,
- int64 /* frame_id */)
+IPC_MESSAGE_ROUTED0(FrameHostMsg_Detach)
// Sent when the renderer starts a provisional load for a frame.
IPC_MESSAGE_ROUTED4(FrameHostMsg_DidStartProvisionalLoadForFrame,
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/test/mock_render_thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698