content/browser/frame_host/render_frame_host_impl.h - Issue 172063002: Unify frame IDs with RenderFrameHost routing IDs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 172063002: Unify frame IDs with RenderFrameHost routing IDs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix type Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/render_frame_host_impl.h

diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h

index 3cdb03539d6d1cdb35fb6be099d297460eb35f36..d79e6634851b961179c68025860aacfafc07538f 100644

--- a/content/browser/frame_host/render_frame_host_impl.h

+++ b/content/browser/frame_host/render_frame_host_impl.h

@@ -56,9 +56,7 @@ class CONTENT_EXPORT RenderFrameHostImpl : public RenderFrameHost {

void Init();

int routing_id() const { return routing_id_; }

- void OnCreateChildFrame(int new_frame_routing_id,

- int64 parent_frame_id,

- int64 frame_id,

+ void OnCreateChildFrame(int new_routing_id,

const std::string& frame_name);

RenderViewHostImpl* render_view_host() { return render_view_host_; }

@@ -124,7 +122,7 @@ class CONTENT_EXPORT RenderFrameHostImpl : public RenderFrameHost {

friend class TestRenderViewHost;

// IPC Message handlers.

- void OnDetach(int64 parent_frame_id, int64 frame_id);

+ void OnDetach();

void OnDidStartProvisionalLoadForFrame(int64 frame_id,

int64 parent_frame_id,

bool main_frame,