Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 172063002: Unify frame IDs with RenderFrameHost routing IDs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Clean up Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 442 matching lines...) Expand 10 before | Expand all | Expand 10 after
453 return media_player_manager_.get(); 453 return media_player_manager_.get();
454 } 454 }
455 455
456 void DidSelectPopupMenuItems(const std::vector<int>& selected_indices); 456 void DidSelectPopupMenuItems(const std::vector<int>& selected_indices);
457 void DidCancelPopupMenu(); 457 void DidCancelPopupMenu();
458 #endif 458 #endif
459 459
460 // User rotated the screen. Calls the "onorientationchange" Javascript hook. 460 // User rotated the screen. Calls the "onorientationchange" Javascript hook.
461 void SendOrientationChangeEvent(int orientation); 461 void SendOrientationChangeEvent(int orientation);
462 462
463 // TODO(creis): Remove this when we replace frame IDs with RenderFrameHost
464 // routing IDs.
465 int64 main_frame_id() const {
466 return main_frame_id_;
467 }
468 int main_frame_routing_id() const { 463 int main_frame_routing_id() const {
469 return main_frame_routing_id_; 464 return main_frame_routing_id_;
470 } 465 }
471 466
472 // Set the opener to null in the renderer process. 467 // Set the opener to null in the renderer process.
473 void DisownOpener(); 468 void DisownOpener();
474 469
475 // Turn on accessibility testing. The given callback will be run 470 // Turn on accessibility testing. The given callback will be run
476 // every time an accessibility notification is received from the 471 // every time an accessibility notification is received from the
477 // renderer process, and the accessibility tree it sent can be 472 // renderer process, and the accessibility tree it sent can be
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
691 // Whether the initial empty page of this view has been accessed by another 686 // Whether the initial empty page of this view has been accessed by another
692 // page, making it unsafe to show the pending URL. Usually false unless 687 // page, making it unsafe to show the pending URL. Usually false unless
693 // another window tries to modify the blank page. Always false after the 688 // another window tries to modify the blank page. Always false after the
694 // first commit. 689 // first commit.
695 bool has_accessed_initial_document_; 690 bool has_accessed_initial_document_;
696 691
697 // The current state of this RVH. 692 // The current state of this RVH.
698 // TODO(nasko): Move to RenderFrameHost, as this is per-frame state. 693 // TODO(nasko): Move to RenderFrameHost, as this is per-frame state.
699 RenderViewHostImplState rvh_state_; 694 RenderViewHostImplState rvh_state_;
700 695
701 // The frame id of the main (top level) frame. This value is set on the
702 // initial navigation of a RenderView and reset when the RenderView's
703 // process is terminated (in RenderProcessGone).
704 // TODO(creis): Remove this when we switch to routing IDs for frames.
705 int64 main_frame_id_;
706
707 // Routing ID for the main frame's RenderFrameHost. 696 // Routing ID for the main frame's RenderFrameHost.
708 int main_frame_routing_id_; 697 int main_frame_routing_id_;
709 698
710 // If we were asked to RunModal, then this will hold the reply_msg that we 699 // If we were asked to RunModal, then this will hold the reply_msg that we
711 // must return to the renderer to unblock it. 700 // must return to the renderer to unblock it.
712 IPC::Message* run_modal_reply_msg_; 701 IPC::Message* run_modal_reply_msg_;
713 // This will hold the routing id of the RenderView that opened us. 702 // This will hold the routing id of the RenderView that opened us.
714 int run_modal_opener_id_; 703 int run_modal_opener_id_;
715 704
716 // Set to true when there is a pending ViewMsg_ShouldClose message. This 705 // Set to true when there is a pending ViewMsg_ShouldClose message. This
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
777 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl); 766 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl);
778 }; 767 };
779 768
780 #if defined(COMPILER_MSVC) 769 #if defined(COMPILER_MSVC)
781 #pragma warning(pop) 770 #pragma warning(pop)
782 #endif 771 #endif
783 772
784 } // namespace content 773 } // namespace content
785 774
786 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 775 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698