Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1720623002: Skip two-pointer fillers when processing marking deque. (Closed)

Created:
4 years, 10 months ago by ulan
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Skip two-pointer fillers when processing marking deque. Slots filtering of left-trimmed arrays assume that two-pointer fillers are not marked. BUG=chromium:585787 LOG=NO TBR=hpayer@chromium.org Committed: https://crrev.com/be4597a29a07ed8a77fa33927c6c0adeecbc649f Cr-Commit-Position: refs/heads/master@{#34177}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M src/heap/incremental-marking.cc View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
ulan
Since this is a fix for a top crasher, I am going to tbr it ...
4 years, 10 months ago (2016-02-20 17:37:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720623002/1
4 years, 10 months ago (2016-02-20 17:38:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-20 18:03:03 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-20 18:03:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be4597a29a07ed8a77fa33927c6c0adeecbc649f
Cr-Commit-Position: refs/heads/master@{#34177}

Powered by Google App Engine
This is Rietveld 408576698