Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 172061: Don't use the AI_ADDRCONFIG flag on Mac OS X. It's not necessary.... (Closed)

Created:
11 years, 4 months ago by wtc
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai, eroman
CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, willchan no longer on Chromium
Visibility:
Public.

Description

Don't use the AI_ADDRCONFIG flag on Mac OS X. It's not necessary. Hopefully this will fix issue 12711. R=eroman,mark BUG=http://crbug.com/12711 TEST=covered by existing unit tests and normal browsing on Mac Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23590

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M net/base/host_resolver_proc.cc View 1 2 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wtc
11 years, 4 months ago (2009-08-17 20:55:01 UTC) #1
Mark Mentovai
LG as discussed on IRC. The comment is confusing to me.
11 years, 4 months ago (2009-08-17 20:59:51 UTC) #2
wtc
Mark, could you review the updated comment in Patch Set 3? Is it clear now?
11 years, 4 months ago (2009-08-17 22:03:50 UTC) #3
Mark Mentovai
11 years, 4 months ago (2009-08-17 22:08:27 UTC) #4
That's clearer.  LGTM.

Powered by Google App Engine
This is Rietveld 408576698