Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: chrome/browser/resources/settings/people_page/change_picture.html

Issue 1720533002: Settings People Revamp: Change Picture: Add accessibility-key usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0095-settings-change-picture-announce-messags-old-image-alt-text
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/change_picture.html
diff --git a/chrome/browser/resources/settings/people_page/change_picture.html b/chrome/browser/resources/settings/people_page/change_picture.html
index be7bd44427856620721fef717631c48d345938e0..bfd8002a4d9259641f9f20ba341c1b2dabd447ef 100644
--- a/chrome/browser/resources/settings/people_page/change_picture.html
+++ b/chrome/browser/resources/settings/people_page/change_picture.html
@@ -1,5 +1,6 @@
<link rel="import" href="chrome://resources/html/i18n_behavior.html">
<link rel="import" href="chrome://resources/html/util.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/iron-a11y-keys/iron-a11y-keys.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/image-icons.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-selector/iron-selector.html">
@@ -13,7 +14,10 @@
<link rel="import" type="css" href="change_picture.css">
<template>
<style include="settings-shared"></style>
- <div id="container" class="settings-box">
+ <div id="container" class="settings-box" tabindex="0">
+ <iron-a11y-keys keys="up down left right space enter"
+ on-keys-pressed="onKeysPress_">
+ </iron-a11y-keys>
<div id="availableIcons" class="start">
<iron-selector id="selector" on-iron-activate="onImageActivate_"
selected-item="{{selectedItem_}}">
@@ -51,7 +55,7 @@
i18n-values="title:discardPhoto" on-tap="onTapDiscardOldImage_">
</paper-icon-button>
</div>
- <settings-camera
+ <settings-camera id="camera"
camera-active="[[isCameraActive_(cameraPresent_, selectedItem_)]]"
on-phototaken="onPhotoTaken_">
</div>

Powered by Google App Engine
This is Rietveld 408576698