Issue 172052: Makes UMA log upload work on non-Windows platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 172052: Makes UMA log upload work on non-Windows platforms. (Closed)

Created:
11 years, 4 months ago by Chris Masone

Modified:
9 years, 7 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Makes UMA log upload work on non-Windows platforms. MemoryDetails::StartFetch() isn't implemented, thus it was never signalling that it was done fetching memory details. Now it does. BUG=15418 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23602

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/common/temp_scaffolding_stubs.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

LGTM Please be sure to test by watching that we get all the way to ...

11 years, 4 months ago (2009-08-17 19:00:58 UTC) #2

jar (doing other things)

Please also be sure to run the unit tests on you linux box, since it ...

11 years, 4 months ago (2009-08-17 19:02:16 UTC) #3

Chris Masone

11 years, 4 months ago (2009-08-17 21:09:11 UTC) #4

On Mon, Aug 17, 2009 at 7:00 PM, <jar@chromium.org> wrote:

> LGTM
>
> Please be sure to test by watching that we get all the way to the
> sending of the POST and a response code is received.


Verified; we get back a 200


>
>
> Thanks,
>
> Jim
>
>
> http://codereview.chromium.org/172052
>

Expand Messages | Collapse Messages