Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1720473002: Support StackTrace.current (Closed)

Created:
4 years, 10 months ago by vsm
Modified:
4 years, 10 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org, yjbanov, kevmoo
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support StackTrace.current This was recently added to the Dart SDK. Breaking Angular in DDC via stack_trace package. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/1bc82b48970b18fb6e183f04d204e61a80770445

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -4 lines) Patch
M lib/runtime/dart/core.js View 1 chunk +19 lines, -1 line 0 comments Download
M test/codegen/expect/collection/src/queue_list.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M tool/input_sdk/lib/core/stacktrace.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M tool/input_sdk/patch/core_patch.dart View 1 chunk +21 lines, -0 lines 1 comment Download
M tool/sdk_expected_errors.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
4 years, 10 months ago (2016-02-19 22:13:21 UTC) #3
Jennifer Messerly
lgtm https://codereview.chromium.org/1720473002/diff/1/tool/input_sdk/patch/core_patch.dart File tool/input_sdk/patch/core_patch.dart (right): https://codereview.chromium.org/1720473002/diff/1/tool/input_sdk/patch/core_patch.dart#newcode459 tool/input_sdk/patch/core_patch.dart:459: @NoInline() I think I've been removing these, they're ...
4 years, 10 months ago (2016-02-19 22:23:56 UTC) #4
vsm
4 years, 10 months ago (2016-02-19 22:25:31 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1bc82b48970b18fb6e183f04d204e61a80770445 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698