Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 172046: A canvas_paint for OS X. (Closed)

Created:
11 years, 4 months ago by Nico
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

A canvas_paint for OS X. Makes it possible to use skia to paint something into a bitmap and then blit that bitmap to screen. I need this so that I can call download_util::PaintDownloadProgress(), which needs an SkCanvas. To be used like this: { gfx::CanvasPaint canvas(myRect); canvas.set_composite_alpha(true); download_util::PaintDownloadprogres(&canvas, ...); } BUG=18902 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23551

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -3 lines) Patch
M app/gfx/canvas_paint.h View 1 chunk +0 lines, -2 lines 0 comments Download
M app/resource_bundle.h View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/canvas_paint.h View 1 chunk +2 lines, -0 lines 0 comments Download
A skia/ext/canvas_paint_mac.h View 1 chunk +104 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
11 years, 4 months ago (2009-08-17 16:18:22 UTC) #1
Amanda Walker
LGTM, though it's a little more code than I like to see in a header ...
11 years, 4 months ago (2009-08-17 16:56:40 UTC) #2
Nico
11 years, 4 months ago (2009-08-17 17:11:32 UTC) #3
In my defense, the gtk and win versions have about the same amount of
code in the header file. And only foolish hobgoblins mind a little
consistency, as the saying goes :-)

On Mon, Aug 17, 2009 at 9:56 AM, <amanda@chromium.org> wrote:
> LGTM, though it's a little more code than I like to see in a header
> file.
>
>
> http://codereview.chromium.org/172046
>

Powered by Google App Engine
This is Rietveld 408576698