Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1720443002: remove supports4f flag for colorfilters (Closed)

Created:
4 years, 10 months ago by reed1
Modified:
4 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -25 lines) Patch
M include/core/SkColorFilter.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/core/SkColorFilter.cpp View 3 chunks +15 lines, -7 lines 0 comments Download
M src/core/SkColorFilterShader.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkColorMatrixFilterRowMajor255.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkModeColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SkColor4fTest.cpp View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
reed1
ptal
4 years, 10 months ago (2016-02-19 20:42:32 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720443002/1
4 years, 10 months ago (2016-02-19 20:42:42 UTC) #5
mtklein
lgtm
4 years, 10 months ago (2016-02-19 20:45:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720443002/1
4 years, 10 months ago (2016-02-19 21:17:49 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 21:38:56 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c5b1228141bd26d4573552a00ebeb0b85a4768df

Powered by Google App Engine
This is Rietveld 408576698