Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1720433003: SDK stuff: Add a script to download the mojom parser binary. (Closed)

Created:
4 years, 10 months ago by viettrungluu
Modified:
4 years, 10 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

SDK stuff: Add a script to download the mojom parser binary. (Using another new, added script that downloads/verifies stuff from Google Storage.) R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/f3863544703bc137eb19bc8516c1ae008795d74b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -41 lines) Patch
M sdk_build/build_sdk.py View 3 chunks +43 lines, -15 lines 0 comments Download
A sdk_build/data/common/download_file_from_google_storage.py View 1 chunk +68 lines, -0 lines 0 comments Download
A sdk_build/data/common/download_mojom_parser.sh View 1 chunk +29 lines, -0 lines 0 comments Download
M sdk_build/data/cpp/cpp.sdk View 1 chunk +36 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 10 months ago (2016-02-19 20:29:03 UTC) #1
vardhan
lgtm
4 years, 10 months ago (2016-02-19 20:43:45 UTC) #2
viettrungluu
4 years, 10 months ago (2016-02-19 22:19:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f3863544703bc137eb19bc8516c1ae008795d74b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698