Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2228)

Unified Diff: content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java

Issue 172043002: Fix a crash of the Content Shell for Android when showing videos in a ContentVideoView. (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/android/java/src/org/chromium/content_shell/ShellManager.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java
===================================================================
--- content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java (revision 251875)
+++ content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java (working copy)
@@ -10,7 +10,6 @@
import android.text.TextUtils;
import android.util.Log;
import android.view.KeyEvent;
-import android.view.View;
import android.widget.Toast;
import org.chromium.base.BaseSwitches;
@@ -18,11 +17,8 @@
import org.chromium.base.MemoryPressureListener;
import org.chromium.base.library_loader.LibraryLoader;
import org.chromium.base.library_loader.ProcessInitException;
-import org.chromium.content.browser.ActivityContentVideoViewClient;
import org.chromium.content.browser.BrowserStartupController;
-import org.chromium.content.browser.ContentVideoViewClient;
import org.chromium.content.browser.ContentView;
-import org.chromium.content.browser.ContentViewClient;
import org.chromium.content.browser.DeviceUtils;
import org.chromium.content.common.ContentSwitches;
import org.chromium.content_shell.Shell;
@@ -116,30 +112,6 @@
shellUrl = savedInstanceState.getString(ACTIVE_SHELL_URL_KEY);
}
mShellManager.launchShell(shellUrl);
- getActiveContentView().setContentViewClient(new ContentViewClient() {
- @Override
- public ContentVideoViewClient getContentVideoViewClient() {
- return new ActivityContentVideoViewClient(ContentShellActivity.this) {
- @Override
- public void onShowCustomView(View view) {
- super.onShowCustomView(view);
- if (CommandLine.getInstance().hasSwitch(
- ContentSwitches.ENABLE_OVERLAY_FULLSCREEN_VIDEO_SUBTITLE)) {
- mShellManager.setOverlayVideoMode(true);
- }
- }
-
- @Override
- public void onDestroyContentVideoView() {
- super.onDestroyContentVideoView();
- if (CommandLine.getInstance().hasSwitch(
- ContentSwitches.ENABLE_OVERLAY_FULLSCREEN_VIDEO_SUBTITLE)) {
- mShellManager.setOverlayVideoMode(false);
- }
- }
- };
- }
- });
}
private void initializationFailed() {
« no previous file with comments | « content/shell/android/java/src/org/chromium/content_shell/ShellManager.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698