Ship the Credential Management API by default

Ship the Credential Management API by default

This patch enables the Credential Management API by default.

It also converts the existing CLI flag into a `base::Feature`, which will allow
us to hook it up to Finch as a kill-switch in case it asplodes the internets.
This feature flag can be removed after ~a release, once we're confident that
we're not breaking things.

Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7ouLjWzcjb0

BUG=576705
R=vabr@chromium.org

Committed: https://crrev.com/062c94e083bb1a2ec9df0222cdbdff6b364cb466
Cr-Commit-Position: refs/heads/master@{#377276}

[Mike West, 2016-02-23 15:07:54]

The CQ bit was checked by mkwst@chromium.org to run a CQ dry run

[Mike West, 2016-02-23 15:08:05]

Mind taking a look, Vaclav?

[commit-bot: I haz the power, 2016-02-23 15:08:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1720403003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1720403003/1

[Mike West, 2016-02-23 15:16:08]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org

[Mike West, 2016-02-23 15:16:08]

jochen@: Would you mind stamping this?

[jochen (gone - plz use gerrit), 2016-02-23 15:19:02]

why would you launch a web api via finch as opposed to enabling it 100% or using
the experimentation framework?

[vabr (Chromium), 2016-02-23 15:29:03]

lgtm

[Mike West, 2016-02-23 15:32:53]

On 2016/02/23 at 15:19:02, jochen wrote:
> why would you launch a web api via finch as opposed to enabling it 100%

In case of explosion, I'd like an off-switch. I tend to break the Internets, you
see.

> using the experimentation framework?

Once it ships, I'd be happy to use it. As is, it's not clear to me if this
particular feature will beat it out of the gate.

[commit-bot: I haz the power, 2016-02-23 16:20:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 16:20:41]

Dry run: This issue passed the CQ dry run.

[Mike West, 2016-02-24 09:26:22]

Description was changed from

==========
Convert the credential management API toggle into a base::Feature.

This conversion will simplify the process of launching the feature, as
it takes care of the work we'd need to do to tie the command-line flag
to Finch.

BUG=576705
R=vabr@chromium.org
==========

to

==========
Ship the Credential Management API by default

This patch enables the Credential Management API by default.

It also converts the existing CLI flag into a `base::Feature`, which will allow
us to hook it up to Finch as a kill-switch in case it asplodes the internets.
This feature flag can be removed after ~a release, once we're confident that
we're not breaking things.

Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7ouLjWzcjb0


BUG=576705
R=vabr@chromium.org
==========

[Mike West, 2016-02-24 09:27:26]

On 2016/02/23 at 15:32:53, Mike West wrote:
> On 2016/02/23 at 15:19:02, jochen wrote:
> > why would you launch a web api via finch as opposed to enabling it 100%
> 
> In case of explosion, I'd like an off-switch. I tend to break the Internets,
you see.
> 
> > using the experimentation framework?
> 
> Once it ships, I'd be happy to use it. As is, it's not clear to me if this
particular feature will beat it out of the gate.

The I2S was approved; I've adjusted this patch accordingly to enable things by
default.

I'd still like a kill switch, however. If something like this patch isn't the
right way to approach that, how would you suggest that I proceed?

[Mike West, 2016-02-24 09:28:16]

mkwst@chromium.org changed reviewers:
+ philipj@opera.com

[Mike West, 2016-02-24 09:28:16]

Also, +philipj@, as this is probably something that Opera will want to disable
until they've taken a look at the UI bits and pieces Chrome has put together,
and decided on the approach that they'll take to the same.

[Mike West, 2016-02-24 09:31:08]

The CQ bit was checked by mkwst@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-24 09:33:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1720403003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1720403003/20001

[philipj_slow, 2016-02-24 09:41:22]

third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in LGTM, and thanks
for the heads up!

[commit-bot: I haz the power, 2016-02-24 11:04:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 11:04:48]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jochen (gone - plz use gerrit), 2016-02-24 11:29:19]

lgtm

[Mike West, 2016-02-24 11:32:59]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2016-02-24 11:32:59]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
philipj@opera.com, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1720403003/#ps40001
(title: "Test.")

[commit-bot: I haz the power, 2016-02-24 11:34:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1720403003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1720403003/40001

[commit-bot: I haz the power, 2016-02-24 12:55:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-24 12:57:08]

Description was changed from

==========
Ship the Credential Management API by default

This patch enables the Credential Management API by default.

It also converts the existing CLI flag into a `base::Feature`, which will allow
us to hook it up to Finch as a kill-switch in case it asplodes the internets.
This feature flag can be removed after ~a release, once we're confident that
we're not breaking things.

Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7ouLjWzcjb0


BUG=576705
R=vabr@chromium.org
==========

to

==========
Ship the Credential Management API by default

This patch enables the Credential Management API by default.

It also converts the existing CLI flag into a `base::Feature`, which will allow
us to hook it up to Finch as a kill-switch in case it asplodes the internets.
This feature flag can be removed after ~a release, once we're confident that
we're not breaking things.

Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7ouLjWzcjb0

BUG=576705
R=vabr@chromium.org

Committed: https://crrev.com/062c94e083bb1a2ec9df0222cdbdff6b364cb466
Cr-Commit-Position: refs/heads/master@{#377276}
==========

[commit-bot: I haz the power, 2016-02-24 12:57:10]

Patchset 3 (id:??) landed as
https://crrev.com/062c94e083bb1a2ec9df0222cdbdff6b364cb466
Cr-Commit-Position: refs/heads/master@{#377276}